#263 GCI task - Link the social media handles in Fedora Happiness Packets - Fedora Project
Merged 4 years ago by jflory7. Opened 4 years ago by p4r4xor.
fedora-commops/ p4r4xor/fedora-happiness-packets master  into  master

file modified
+4 -1
@@ -109,7 +109,10 @@ 

                    <div class="socio-buttons">

                    <a href="https://www.facebook.com/TheFedoraProject"><i class="fab fa-facebook-f fa-lg"></i></a>

                    <a href="https://twitter.com/fedora"><i class="fab fa-twitter fa-lg"></i></a>

-                   <a href="https://plus.google.com/112917221531140868607"><i class="fab fa-google-plus-g fa-lg"></i></a>

+                   <a href="https://www.instagram.com/thefedoraproject/"><i class="fab fa-instagram fa-lg"></i></a>

+                   <a href="https://www.reddit.com/r/Fedora/"><i class="fab fa-reddit fa-lg"></i></a>

+                   <a href="https://telegram.me/fedoranews"><i class="fab fa-telegram fa-lg"></i></a>    

+                   <div class="footer-msg" style="padding-bottom: 1rem;">

                  </div>

                </small>

              </footer>

file modified
+3
@@ -2,10 +2,13 @@ 

  	<p>Share <span class="wearefedora">#WeAreFedora </span> </p>

  </div>

  <div class="row">

+     <!--

  	<a class="g-interactivepost sharebutton google" data-contenturl="https://happinesspackets.fedorainfracloud.org/" data-clientid="427442962349-biuc5ks65luss5h3v5oqtj15jigaqoib.apps.googleusercontent.com" data-cookiepolicy="single_host_origin" data-prefilltext="#WeAreFedora" data-calltoactionurl="http://plus.google.com/pages/create"><i class="fab fa-google-plus-g fa-lg"></i> Share </a>

  	<script type="text/javascript">(function() {var po = document.createElement('script'); po.type = 'text/javascript'; po.async = true; po.src = 'https://apis.google.com/js/client:plusone.js'; var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(po, s);})();</script>

  	<a id="fb" class="sharebutton"><i class="fab fa-facebook fa-lg"></i> Share </a>

  	<script>document.getElementById('fb').onclick = function() {FB.ui({method: 'share', mobile_iframe: true, hashtag: '#WeAreFedora', href: 'https://happinesspackets.fedorainfracloud.org/',}, function(response){});}</script>

  	<a href="https://twitter.com/intent/tweet?button_hashtag=WeAreFedora" class="sharebutton twitter" data-size="large" data-dnt="true"><i class="fab fa-twitter fa-lg"></i> Tweet </a>

  	<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script>

+     -->

  </div>

+ 

There weren't much changes, I had to remove the follow.html part due everyone's configurations with browser extensions. G+ has been taken down which makes it useless, Facebook's problem arises due to window.history.pushState() which wipes out history after a navigation has occured. Much can't be done for facebook as window.history.pushState() is very commonly used in react applications and Facebook is the creator of react :). Another reason is the usage of target='_blank' in Facebook which also is a problem for the redirection.

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, type - frontend, type - summer coding
- Request assigned

4 years ago

Thanks for this contribution @p4r4xor, looks good! Merging. :clapper:

Pull-Request has been merged by jflory7

4 years ago