fedora-commops / fedora-happiness-packets

#224 i have removed a duplicate send some happiness now! button from th start page
Merged by jflory7. Opened by saidat.
fedora-commops/ saidat/fedora-happiness-packets correction1  into  master

Download 224.patch

i have removed a second "send some happiness button now! " button from a start page since two button were doing th same thing

Hi @saidat, thanks for the PR. I verified the button is gone when I tested your changes. Before merging, I suggest two changes:

  • For the old button HTML, please remove it instead of commenting it out.

Reason: Since we use git, it's easy to look backwards later and "undo" a commit or change. It is better practice to delete lines instead of commenting them out if you are confident it isn't a temporary change.

  • Instead of deleting the bottom button, keep the top button and remove the lower button.

Reason: For our web application, sending a Happiness Packet is the most important activity. Since it is most important, I think it is better to keep it higher on the page and easier to catch the viewer's attention.

Can you please make these changes to this pull request? Thanks @saidat!

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, needs changes, type - frontend, type - summer coding
- Request assigned

1 new commit added

  • i have removed a duplicate button from the start html page

hello @jflory7 , if you get time can you please go through my pr, i have made changes as you told me . Thanks

Metadata Update from @jflory7:
- Pull-request untagged with: needs changes

Hi @saidat! This looks ready to go. Thanks for working on it. Merging! :clapper:

Pull-Request has been merged by jflory7

Hi @saidat! This looks ready to go. Thanks for working on it. Merging! 🎬

Your welcome @jflory7

Metadata
jflory7

PASSED improvement type - frontend type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.