fedora-commops / fedora-happiness-packets

Clone
Source Code
GIT

#212 adding a search button to FAS input field
Closed 5 years ago by jflory7. Opened 5 years ago by saidat.
fedora-commops/ saidat/fedora-happiness-packets search  into  master

file modified
+4 -1 
@@ -5,7 +5,7 @@ 
 

  from datetime import timedelta
 

  

  from crispy_forms.helper import FormHelper
 

- from crispy_forms.layout import Submit, Layout, Fieldset, HTML
 

+ from crispy_forms.layout import Submit, Layout, Fieldset, ButtonHolder, HTML
 

  from django import forms
 

  from django.conf import settings
 

  from django.urls import reverse
 
@@ -59,6 +59,9 @@ 
 

              Fieldset("Privacy and permissions", 'sender_named', 'sender_approved_public', 'sender_approved_public_named'),
 

              HTML("<br>"),
 

              Submit('submit', 'Send some happiness', css_class='btn-lg centered'),
 

+             ButtonHolder(
 

+                 Submit('submit', 'Submit', css_class='button white')
 

+             )
 

          )
 

  

      def clean(self):

I am adding a search button to the FAS input field

Metadata Update from @jflory7:
- Pull-request tagged with: needs changes
- Request assigned
5 years ago

Hi @saidat, did you test this change? I tested this and it didn't work for me. The Submit button is at the bottom of the page and does not appear on the search bar. When I entered a FAS username and clicked Submit, it did not fill in the name/email boxes.

If you have time, please take another look and see if you can get this working. For now, I am closing this PR since this change is incomplete.

Pull-Request has been closed by jflory7
5 years ago

Hi @saidat, did you test this change? I tested this and it didn't work for me. The Submit button is at the bottom of the page and does not appear on the search bar. When I entered a FAS username and clicked Submit, it did not fill in the name/email boxes.
If you have time, please take another look and see if you can get this working. For now, I am closing this PR since this change is incomplete.

hello @jflory7, i tried testing it but when i loaded the happiness packets i didnt see the FAS input field can you please direct me where i can get it from because i only see it when logging into fedora account of which am already logged in so i test it with that one . can you please direct me where i can find it

hello @jflory7, i tried testing it but when i loaded the happiness packets i didnt see the FAS input field can you please direct me where i can get it from because i only see it when logging into fedora account of which am already logged in so i test it with that one . can you please direct me where i can find it

Yes @saidat you will be able to send a happiness packet only when you are logged in. After you log in, scroll down to the bottom of the page, you will be able to see the changes you made.
Metadata

needs changes

Changes Summary 1
+4 -1
file changed
happinesspackets/messaging/forms.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.