#206 Updated issue 201: Solved the sidebar scrolling by making text size smaller and editing footer and other pages accordingly, fixed more mobile view problem
Merged 5 years ago by jflory7. Opened 5 years ago by anhpham.
fedora-commops/ anhpham/fedora-happiness-packets updated-issue-201-sidebar-large-dimensions  into  master

file modified
+18 -4
@@ -18,7 +18,7 @@ 

  body {

      font-family: 'Open Sans';

      line-height: 1.8em;

-     font-size: 16px;

+     font-size: 9px;

      height: 100%;

      position: relative;

      margin: 0;
@@ -99,6 +99,10 @@ 

      margin-top: 1em;

  }

  

+ fieldset .form-group{

+     font-size: 1.7em;

+ }

+ 

  fieldset legend {

      font-family: 'Montserrat';

      font-style: italic;
@@ -107,13 +111,14 @@ 

  

  blockquote {

      border-left: 0px;

-     font-size: 16px;

+     font-size: 2rem;

      color: rgba(0, 0, 0, 0.7);

      background: url(/static/images/loveletter.png) no-repeat;

      background-size: 20%;

      background-position: 0 20px;

      padding-left: calc(20% + 20px);

      min-height: 120px;

+     line-height: 1.8em;

  }

  

  .centered {
@@ -281,7 +286,12 @@ 

  

  @media (max-width: 360px) {

      .btn-responsive {

-         font-size: 15px;

+         font-size: 12.5px;

+         margin: 2em 0;

+     }

+ 

+     main .container{

+         margin-bottom: 19em;

      }

  }

  
@@ -303,7 +313,9 @@ 

      font-size:2.3rem;

  }

  .footer-msg {

-     padding-top: 0.5rem;

+     padding-bottom: 1rem;

+     font-size: 16px;

+     line-height: 1.8em;

  }

  .footer-msg p {

    font-size: 2rem;
@@ -313,6 +325,7 @@ 

  }

  .row p {

      font-size: 2rem;

+     line-height: 1.8em;

  }

  .footer-share p{

      font-size: 2rem;
@@ -320,6 +333,7 @@ 

  .socio-buttons {

      padding: 1rem;

      font-size: 2rem;

+     padding-bottom: 0.5em;

  }

  .socio-buttons a {

      padding: 0.9rem;

file modified
+1 -1
@@ -93,7 +93,7 @@ 

                    <hr>

                    {% block footer %}

                    {% include "follow.html" %}

-                   <div class="footer-msg">

+                   <div class="footer-msg" style="padding-top: 1rem;">

                      {% endblock %}

                      Fedora Happiness Packets is a fork of <a href="https://github.com/mxsasha/happinesspackets/">Happiness Packets</a> and part of GSoC 2018.

                      <br>

@@ -6,7 +6,7 @@ 

          <h2>Get inspired!</h2>

      </div>

  

-     <em>

+     <em style="font-size: 1.5em; line-height: 1.8em;">

          Want to send some happiness but having a writer's block? Check out some of these sample messages

          for inspiration. These are not actual messages that were sent with the system, just some ideas that

          you can use. Our <a href="{% url 'messaging:archive' %}">Happiness Archive</a> contains more messages from

@@ -16,8 +16,4 @@ 

      <a href="https://twitter.com/intent/tweet?button_hashtag=WeAreFedora&text=I%20just%20sent%20a%20happiness%20packet%20to%20thank%20a%20@fedora%20community%20member" class="twitter-hashtag-button" data-size="large" data-dnt="true">Tweet #WeAreFedora</a>

      <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script>

  

- {% endblock content %}

- 

- {% block footer %}

-     {% include "follow.html" %}

- {% endblock %} 

\ No newline at end of file

+ {% endblock content %} 

\ No newline at end of file

file modified
+1 -1
@@ -4,7 +4,7 @@ 

  <h2>Search</h2>

  <form method="get"  class="form-inline">

      {% for field in form %}

-     <div class="form-group">

+     <div class="form-group" style="font-size: 1.7em;">

          {{ field.errors }}

          {{ field.label_tag }} {{ field }}

      </div>

I had problem rebasing my last pull request with new changes to the code base, so I had to make a new pull request and updated all changes.
My third pull request is to solve the problem of sidebar scrolling in large dimensions.
This commit includes:
1. Made the body text size smaller
2. The body text size is smaller, leading to the fact that some other pages look unbalanced and distorted. I adjusted the font size and line height to make all of them look normal accordingly.
3. The issue with mobile view that was commented in issue #134 has been fixed as well.
4. UPDATED: Made the padding from Total Happiness Packets in sidebar smaller.
5. Tested all changes in all dimensions: looks good!

As per issue 201: https://pagure.io/fedora-commops/fedora-happiness-packets/issue/201

@jflory7 here is my Pull Request! Do let me know if anything doesn't look right! thumbs up

rebased onto dbf71ee

5 years ago

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, type - frontend, type - summer coding
- Request assigned

5 years ago

Hi @anhpham, I tested this and the change looks good. Merging! :clapper:

Pull-Request has been merged by jflory7

5 years ago