fedora-commops / fedora-happiness-packets

#205 Solved the sidebar scrolling by making text size smaller and editing footer and other pages accordingly, fixed more mobile view problem
Closed by anhpham. Opened by anhpham.
fedora-commops/ anhpham/fedora-happiness-packets issue-201-sidebar-large-dimensions  into  master

Download 205.patch

My third pull request is to fixing the sidebar scrolling bug in large dimensions.
This commit includes:
1. Changing the body text size from 16px to 9px to solve the scrolling problem in large dimension.
2. Due to the fact that text size was changed, a couple of text blocks in other pages looked out of place. So I adjusted their font-size and line-height accordingly.
3. The footer's mobile view bug that was mentioned in the discussion of issue 134 also got solved by changing the margin of the main block.
4. Testing all these changes on all devices and views: Looks pretty good so far!

As per issue #201: https://pagure.io/fedora-commops/fedora-happiness-packets/issue/201

Please let me know if there's anything that needs changing :)

@jflory7 Here's my pull request! If you have time, please kindly check it and let me know what else I could change 👍👍

rebased onto c1ea3981cf2404e05a5afc6c8e13f66a65902664

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, needs testing, type - frontend, type - summer coding
- Request assigned

Hi @anhpham, this looks great. It seems to have solved the issue I had.

I have one change request: could you add more spacing between Total Happiness Spread and What are Happiness Packets? They look too close together in my current view:

Two pages in side bar are very close together

Otherwise, everything else looks good! If you can fix up this last part, we can merge the PR. :thumbsup:

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Pull-request tagged with: needs changes

Hi @anhpham, this looks great. It seems to have solved the issue I had.
I have one change request: could you add more spacing between Total Happiness Spread and What are Happiness Packets? They look too close together in my current view:
Two pages in side bar are very close together
Otherwise, everything else looks good! If you can fix up this last part, we can merge the PR. 👍

Sure, I'll be making the change asap! Thank you!
(Also, if you have time, could you please also check your email as well?)

Pull-Request has been closed by anhpham
Metadata
jflory7

PASSED improvement needs changes type - frontend type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.