Volumes added in docker-compose.yaml
@jflory7 I have added the volumes for static files and templates #181 Please take a look.
Metadata Update from @jflory7: - Pull-request tagged with: improvement, type - internal organization, type - summer coding - Request assigned
Metadata Update from @jflory7: - Pull-request tagged with: needs changes
I don't understand the purpose of this volume. Why this path?
This one is almost complete but it won't work as written for systems using SELinux, like CentOS or Fedora. You need to add the SELinux context flag to the volume. See the following resources for an example:
Thanks, @jflory7 for pointing this out. Yes, that path mounts all the content into container which is not that useful. The new volumes are:
volumes: - ./assets:/app/assets - ./templates:/app/templates
where ./assests is in host machine and /app/assets is in container Even after this change, the outcome will be same as desired.
1 new commit added
docker-compose volumes updated
rebased onto 01395e9f878a81858d1fa380fa3bf2018b14aa6d
@jflory7 I made changes in docker-compose.yaml file. Please take a look.`
Hi @revanth, thanks for working on this. Your changes partially addressed my feedback. The new volume paths make sense.
Some things still needed:
For the first, please read the previous links for more info on how to do the SELinux labeling on volumes. For the second, I recommend the feature branch workflow for working on new changes. This article should help guide you on how to do this. If you get stuck, let us know where you get stuck and we'll try to help.
added z option in volumes
@jflory7 I'm stuck at rebasing. I have used - git checkout - git rebase master But still I get Everything to update. Am I missing something 🤔 ?
@jflory7 I am stuck at rebasing, can you please help me with that.
@revanth Hi! Did you try making a feature branch as suggested above by @jflory7 ? Seems like you've merged the commits on upstream with your own commit. You need to roll that back. This has been explained in the PR #186. Please refer the links and explanation provided there. Let us know if you hit a roadblock :)
Pull-Request has been closed by revanth
Volumes added in docker-compose.yaml