#167 add p tag to inspiration
Closed 5 years ago by jflory7. Opened 5 years ago by feisal.
fedora-commops/ feisal/fedora-happiness-packets modify-font  into  master

modified template tags
Feisal • 5 years ago  
@@ -1,43 +1,61 @@ 

- {% extends 'base.html' %}

+ {% extends 'base.html' %

  

  {% block content %}

- 

+     

      <div class="page-header">

+     

          <h2>Get inspired!</h2>

      </div>

- 

+     

      <em>

-         Want to send some happiness but having a writer's block? Check out some of these sample messages

+         <p>Want to send some happiness but having a writer's block? Check out some of these sample messages

          for inspiration. These are not actual messages that were sent with the system, just some ideas that

          you can use. Our <a href="{% url 'messaging:archive' %}">Happiness Archive</a> contains more messages from

-         others that may help inspire you.

+         others that may help inspire you.</p>

      </em>

- 

+     

      <h4>This message was sent to the Django: Under the Hood team</h4>

+     

      <blockquote>

-         <p>

+        <p>

              I feel totally overwhelmed, surprised and very, very grateful. Thank you for caring. You are unbelievable.

              You are a bunch of craziest, the most positive people I've met. You inspire me to give back to community

              even more. I wish I could express properly what I'm feeling right now...

+     

          </p>

- 

+     

          <p>

+     

              May it always rain stroopwafels on you. But not all the time, that could be inconvenient. Only when you

              feel like having stroopwafels. Or someone that you like feels like having stroopwafels. Or you just want

              to make it rain stroopwafels.

+     

          </p>

- 

+     

          <p>

+     

              Sending hugs, you crazy, amazing people!

+     

          </p>

+     

      </blockquote>

- 

+     

      <h4>Another contributed message</h4>

+     

      <blockquote>

-         Thank you for writing such a great article. I’ve seen some of your other writing and ideas and you seem

-         to capture difficult concepts very well. I’m really happy that you’re part of our community, and aspire

-         to be as great in some of these things as you are some day :)

-     </blockquote>

- 

+     

+         <p>Thank you for writing such a great article. I’ve seen some of your other writing and ideas and you seem to capture difficult concepts very well.

+         </p>

  

+         <p>I’m really happy that you’re part of our community, and aspire

+         to be as great in some of these things as you are some day.

+     

+         </p>

+     

+     </blockquote>

+     

+  

+     

+  

+     

  {% endblock content %}

Added p tag to the bottom message

@feisal Could you please format the <p> tag the same way as it does in the previous <blockquote> section? It's helpful to keep the same style for consistency.

Metadata Update from @jflory7:
- Pull-request tagged with: difficulty - easy, improvement, needs changes, type - frontend, type - summer coding
- Request assigned

5 years ago

@jflory7 i followed your suggestion and pasted the screenshot on issue #166. Thank you

1 new commit added

  • format p tag
5 years ago

1 new commit added

  • re-modify
5 years ago

5 new commits added

  • resolve conflict
  • re-p tags
  • re-modify
  • format p tag
  • add p tag to inspiration
5 years ago

Hey @feisal ! I would suggest to squash all your commits to one, since only one file is changed and you have made 8 commits .
These can be helpful.
Don't Be Scared of git rebase
How to Rebase a Pull Request

rebased onto cf367921cf559c170ecfcd4f1635dc43c4ab6018

5 years ago

rebased onto 3e7adf156b50efe2e07c19c22cfa8963727a1cca

5 years ago

rebased onto f0dc39915296780de271b10eed88e893e5cd0f52

5 years ago

@jflory7 Also can you kindly assign issue #34 to me? i would like to work on it

@feisal Your changes do not address my feedback. Could you please maintain the same style as what is already done in the lines above what you changed? Like this.

rebased onto 28aa4bae0aee64933283032c6787d219870ab790

5 years ago

rebased onto bbc307c8706450dcca3e7576180603b2d35d311a

5 years ago

2 new commits added

  • refine template
  • refine template
5 years ago

rebased onto a3f46cf49a7896f54bcefff1326e21b6a2e1300c

5 years ago

1 new commit added

  • modified template tags
5 years ago

rebased onto de510c2

5 years ago

@feisal This isn't what I asked. Instead, this changed the rest of the styling on the page and the section I was looking for changes is still the same.

I think it's better to regroup and focus on a collection of UI/UX improvements with some purpose in mind. Like I mentioned in the other tickets, we are not looking for minor cosmetic tweaks by themselves, but they should have some purpose or goal in mind. I want to better plan our aim first before making several minor tweaks.

Pull-Request has been closed by jflory7

5 years ago

@jflory7 ok kindly re-phrase on the changes you said clearly so that i can work on it and possibly re open the pull request