fedora-commops / fedora-happiness-packets

#165 Display username in the side navigation when user logs in.
Merged by jflory7. Opened by janyu99.
fedora-commops/ janyu99/fedora-happiness-packets display-logged-in-username  into  master

Download 165.patch

1. What is a summary of your change?
This change displays the username as well as other user related links at the top of the side navigation after the user logs in.

2. Why is this change helpful?
This change will help enhance user experience, as it gives the user confirmation/feedback that they successfully logged in, and grouping the functionality at the top of the navigation also helps the user understand that they are now able to access new functionality related to their account.

3. Any specific details to consider?
I moved the 'Send some happiness!' link below the username after the user logs in. Since it is also a user functionality, I figured it should be grouped with the others.

4. What do you think is the outcome of this change?
With this change, it should be clear to the user that they have logged in as the navigation bar should display their username and user related functionality.

5. These changes can be seen here

Metadata Update from @jflory7:
- Pull-request tagged with: needs testing, new change, type - frontend, type - summer coding
- Request assigned

@janyu99 Thanks for this PR! :tada:

It looks like some of the other merged pull requests created a merge conflict with your PR. :astonished: You need to rebase your changes in your branch on top of the master branch. You can read either of these two articles for help rebasing:

Hopefully this is enough to help you fix the conflict. If you get stuck or spend too long fighting with git, let me know and I can try to help. After that, I will test this PR.

rebased onto 97120a3396b96271330599aa264ad865c645a4cf

@jflory7 Thanks for those links, they really helped me understand and execute this new (and quite intimidating) git command! With some additional researching, I think I managed to resolve all the conflicts, and pushed the new changes to my pull request :grin: Let me know if any issues arise :thumbsup:

@janyu99 Thanks, looks like you did it exactly right! Unfortunately, when #64 was merged, it added a lot of changes and created merge conflicts in a lot of pull requests. Could you do this one more time and we will merge this PR ASAP?

Sorry for all the trouble!

rebased onto f02ff9e03e5f44d88d80a22ae8d95a47c9002a5f

@jflory7 No worries! I resolved the conflicts and pushed the new changes. However, it seems another issue has come up regarding fitting every link inside the side navigation. Once the user logs in, the addition of user related links pushes everything down, and thus the 'Search Archive' link is barely visible. We can perhaps merge this first, then create another pull request to improve the side navigation UI?

rebased onto 1bf36dab858853e4ae7224d19be981b61486a808

@janyu99 Thanks, this PR looks great! Merging. :checkered_flag:

And yes, I agree. The navigation side bar is becoming cluttered. It does need some cleaning up. I suggest filing a new ticket for us to discuss and then we can work on improving it. :thumbsup:

Pull-Request has been merged by jflory7

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
Metadata
jflory7

new change type - frontend type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.