#163 Changed label Packets Sent to Total Happiness Spread in navigation bar and added appropriate emoji according to the number of packets sent
Merged 5 years ago by jflory7. Opened 5 years ago by anhpham.
fedora-commops/ anhpham/fedora-happiness-packets fix-issue-145-changed-labels-in-navigation  into  master

file modified
+5 -1
@@ -26,7 +26,11 @@ 

              {% url 'messaging:start' as url %}

              <a href="{{ url }}"><img src="{% static 'images/logo.png' %}" alt="Open-Source Happiness Packets" class="logo"/></a>

              <ul class="nav nav-stacked">

-                 <li><a>Packets sent: <b>{{ packets_sent }}</b></a></li>

+                 {% if packets_sent == 0 %}

+                     <li><a>Total Happiness Spread: <b>{{ packets_sent }} πŸ’”</b></a></li>

+                 {% else %}

+                     <li><a>Total Happiness Spread: <b>{{ packets_sent }} πŸŽ‰</b></a></li>

+                 {% endif %}

                  {% url 'messaging:send' as url %}

                  <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">Send some happiness!</a></li>

                  {% url 'messaging:start' as url %}

My first Pull Request is changing the label in navigation bar for better wording.
This commit commit includes:
1. Changed "Packet Sent" to "Total Happiness Spread" in the navigation bar.
2. Added emoji πŸ’”to display when no packets are exchanged, and emoji πŸŽ‰ when there are packets exchanged using if else.
3. Fixed the indentation in the if/else block as needed.

As per issue 145: https://pagure.io/fedora-commops/fedora-happiness-packets/issue/145

@jflory7 @jonatoni can you check my first pull request? please let me know if there is anything that needs to be fixed. Thank you so much 😊

rebased onto 19295ad

5 years ago

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, type - frontend, type - summer coding
- Request assigned

5 years ago

@anhpham Super! Your changes look good. :thumbsup: Thanks for working on this! Merging. :checkered_flag:

Pull-Request has been merged by jflory7

5 years ago

@jflory7 thank you sincerely! πŸ‘πŸ‘ now i'm starting my second issue, and would ask more questions if stuck as needed!