#140 updated `chmod` from `-x` to `+x` in windows setup document
Merged 5 months ago by jonatoni. Opened 5 months ago by phoenixabhishek.

@@ -34,7 +34,7 @@

  #. Start the Docker application(With elevated/admin access).

  #. Run the client secret generation script::

  

-     chmod -x generate_client_secrets.sh

+     chmod +x generate_client_secrets.sh

      generate_client_secrets.sh

  

      Here, you might get an error saying::

As pointed out here.
Made the necessary changes

Pull-Request has been merged by jonatoni

5 months ago

Oops. I missed that in the last review.

@phoenixabhishek Actually since the file has he executable bit already set in git, I don't think this step is necessary at all. I think it could be omitted from the docs.

@jflory7 so should I change this in the docs..???

@phoenixabhishek If you wanted to verify this is true (i.e. clone the repo fresh and test the insturctions without the step), that would be helpful. If it still works, then a new PR to remove the step is welcome.

Okk, I'll verify this first and then go ahead... :thumbsup: :thumbsup: :thumbsup: :thumbsup: :thumbsup:

@jflory7 It still works, opening a new PR to address this and remove the step.

Metadata