PR#140: updated `chmod` from `-x` to `+x` in windows setup document - fedora-commops/fedora-happiness-packets

fedora-commops / fedora-happiness-packets

#140 updated `chmod` from `-x` to `+x` in windows setup document

Merged 5 years ago by jonatoni. Opened 5 years ago by phoenixabhishek.

Unknown source master into master

updated `chmod` from `-x` to `+x`

Abhishek Y • 5 years ago

a00d976

docs/setup/development_windows.rst

file modified

+1 -1

		`@@ -34,7 +34,7 @@`
		`#. Start the Docker application(With elevated/admin access).`
		`#. Run the client secret generation script::`

		`- chmod -x generate_client_secrets.sh`
		`+ chmod +x generate_client_secrets.sh`
		`generate_client_secrets.sh`

		`Here, you might get an error saying::`

phoenixabhishek commented 5 years ago

As pointed out here.
Made the necessary changes

Pull-Request has been merged by jonatoni

5 years ago

jflory7 commented 5 years ago

Oops. I missed that in the last review.

jflory7 commented 5 years ago

@phoenixabhishek Actually since the file has he executable bit already set in git, I don't think this step is necessary at all. I think it could be omitted from the docs.

phoenixabhishek commented 5 years ago

@jflory7 so should I change this in the docs..???

jflory7 commented 5 years ago

@phoenixabhishek If you wanted to verify this is true (i.e. clone the repo fresh and test the insturctions without the step), that would be helpful. If it still works, then a new PR to remove the step is welcome.

phoenixabhishek commented 5 years ago

Okk, I'll verify this first and then go ahead... :thumbsup: :thumbsup: :thumbsup: :thumbsup: :thumbsup:

phoenixabhishek commented 5 years ago

@jflory7 It still works, opening a new PR to address this and remove the step.