#91 All pages have the same title displayed in the title bar
Closed: complete 5 years ago by jflory7. Opened 5 years ago by saidat.

all pages have the same title called open-source Happiness packets yet the display different information


Hello, @jonatoni
I am an Outreachy applicant and would love to make this issue my first contribution. Could you please assign it to me. Thanks.

hey,
i would like to contribute to this issue and it will also help me for my Outreachy application. Thankyou.

Metadata Update from @jflory7:
- Issue priority set to: waiting on assignee (was: awaiting triage)
- Issue tagged with: PASSED, difficulty - easy, good first issue, help wanted, improvement, type - frontend, type - summer coding, type - upstream

5 years ago

Hi, in the draft of the upcoming contributor guidelines, we talk more about changes that should be sent to the upstream project. This is a good example of a feature to send to the upstream project, mxsasha/happinesspackets.

I will keep the issue open if someone wants to work on this. The pull request should be sent to mxsasha/happinesspackets. However, there are likely better issues to work on. We don't know for sure if upstream will accept the pull request.

ok i am going to work on it

@saidat Okay, thanks. I will assign the ticket to you.

Please follow best practices when opening a new pull request on the upstream project. It's important to submit helpful changes back upstream so they will understand the changes too.

If you need help or guidance, please let us know here or in the #fedora-commops channel (find out how to get in touch here).

Metadata Update from @jflory7:
- Issue untagged with: help wanted
- Issue assigned to saidat

5 years ago

@jflory7 , @saidat If you are not working on this issue, I would like to take this up.

Am working on it
On 28 Feb 2019 09:45, "Richa Gautam" pagure@pagure.io wrote:

richa208 added a new comment to an issue you are following:
@jflory7 , @saidat If you are not working on this issue, I would like to take this up.

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-commops/fedora-happiness-packets/issue/91

i worked on it and created a pull request though the have not merged it yet
https://github.com/mxsasha/happinesspackets/pull/48

i worked on it and created a pull request though the have not merged it yet

Thanks @saidat. If you make a pull request to fedora-happiness-packets with the same changes, we can merge it here too.

hello jflory7, when i try pushing to fedora-happiness packets i get an error 403: forbidden yet i added an ssh key, i dont know why ?
fedora.PNG

@saidat You need to upload a SSH key to Pagure to push to your remote fork. Pagure provides documentation on how to do this here. Did you try following all the steps suggested in the documentation?

Hello @jflory7, am trying to login on the same machine using ubuntu18 but after clicking on login it displays OpenID request Cancelled, I don't know why it behaves that way. And is it fine if you drop me your email that I can use to talk to you private questions just in case I need help . Thank you

@saidat This sounds like a different issue than what this ticket is for. Get in touch with the CommOps team and the other mentors and myself can help you there. 1x1 email is hard for me and sometimes it takes me a few days to get caught up.

@said1995 did you had the chance to open the PR here in our repo? if you facing any problem with that please ask on our IRC channels #fedora-commops #fedora-outreachy or #fedora-summer-coding

i have tried everything but still pops the error. and when i click on my user icon i go to settings but there is no authentical option except the ssh den add but i have done all but still failed to push and to create a pull request because am seeing error:403

@jonatoni , i have asked for the help here is the link https://discussion.fedoraproject.org/t/generating-ssh-key/1181 and i also asked for help concerning docker but didnt get because the one i got was the same as the steps i followed in the README which i had done but still got a problem here is the link https://discussion.fedoraproject.org/t/i-need-help-about-docker-compose-up/1158

please i need help . thank you so much

@saidat Let's use Discourse instead of this ticket to debug your current problem. :thumbsup: Thanks!

I reviewed #185 more in depth and realized there is a better way to implement this than by editing this into each template file. We should make use of the extra_head block in the base.html template to include extra header information, and write this as a new block at the top of each template file.

For example, see the excerpt from base.html:

{% block extra_head %}{% endblock %}

In a file like messaging/faq.html, it might look something like this:

{% block extra_head %}
    <title>Frequently Asked Questions (FAQ)</title>
{% endblock %}

@saidat Does this make sense? If so, could you please update your PR and also edit all HTML template files in templates/?

Metadata Update from @jflory7:
- Issue tagged with: needs changes

5 years ago

ok let me edit them

On Mon, 18 Mar 2019 at 22:34, Justin W. Flory pagure@pagure.io wrote:

jflory7 added a new comment to an issue you are following:
` I reviewed #185 more in depth and realized there is a better way to implement this than by editing this into each template file. We should make use of theextra_headblock in thebase.html` template to include extra
header information, and write this as a new block at the top of each
template file.

For example, see the excerpt
from base.html:

python {% block extra_head %}{% endblock %}

In a file like messaging/faq.html, it might look something like this:

html {% block extra_head %} <title>Frequently Asked Questions (FAQ)</title> {% endblock %}

@saidat Does this make sense? If so, could you please update your PR and
also edit all HTML template files in templates/?
``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-commops/fedora-happiness-packets/issue/91

yes it makes sense let me do edit them.Thanks

Metadata Update from @jflory7:
- Issue untagged with: needs changes
- Issue set to the milestone: Summer Coding 2019: community bonding

5 years ago

This was fixed in #185. Thanks @saidat for working on this! :tada: I am closing this ticket as complete. :clapper:

Metadata Update from @jflory7:
- Issue close_status updated to: complete
- Issue status updated to: Closed (was: Open)

5 years ago

your welcome @Justin W. Flory jflory7@gmail.com

On Wed, 27 Mar 2019 at 04:16, Justin W. Flory pagure@pagure.io wrote:

jflory7 added a new comment to an issue you are following:
This was fixed in #185. Thanks @saidat for working on this! :tada: I am closing this ticket as complete. :clapper:

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-commops/fedora-happiness-packets/issue/91

Login to comment on this ticket.

Attachments 2
Attached 5 years ago View Comment
Attached 5 years ago View Comment