#81 Improving the footer.
Closed: complete 5 years ago by jflory7. Opened 5 years ago by alishapapun.

The following features in the footer can be improved.
1. Removing #WeAreFedora from the buttons in the footer and adding a line "Lets spread #WeAreFedora!" above the buttons.
2. Hover effects on links like "Happiness Packets" , "fedora.happinesspackets@gmail.com" and "here".
3.Adjusting the size of font awesome icons.
4.Adding padding between the icons instead of "&bnsp".
5.Adding suitable background color for differentiating the footer from rest of the page.
Screenshot_from_2019-02-22_19-36-27.png


Hi @jonatoni , I am an Outreachy aspirant, looking forward to contributing to this project.
I have opened this issue so as to improve the look of footer.
Could you please assign the issue to me so that I can work on the issue?

Hi..Is there anyone who successfully ran the module in their localhost?

Hi..Is there anyone who successfully ran the module in their localhost?
It runs but doesn't send the happinness, not event in the published version... I don't know if I'm doing something wrong or is a real issue, can you clarify this please? @jonatoni

@carolinajimenez26 What python version are you using?...In my case i am using python3 and it seems that some dependencies in the module are using python2 and need to be updated @jonatoni i will look at the issue and will give you feedback as soon as possible.

@carolinajimenez26 What python version are you using?...In my case i am using python3 and it seems that some dependencies in the module are using python2 and need to be updated @jonatoni i will look at the issue and will give you feedback as soon as possible.

By defect I'm using python 2.7

Hey @carolinajimenez26 , I don't think discussing these issues here is right.
Can you come over to the IRC channel, I'll try my best to help you there.
thanks :smile:

I recommend to use IRC channel(#fedora-outreachy) for your queries.

Hey @jflory7 could you just review this issue. I would love to hear any improvement I can incorporate in features I put forward in the issue, or anything. Thanks.

Metadata Update from @jflory7:
- Issue assigned to alishapapun
- Issue priority set to: waiting on assignee (was: awaiting triage)
- Issue tagged with: PASSED, difficulty - easy, good first issue, type - frontend, type - summer coding

5 years ago

Hi @alishapapun, the five tasks you list in the ticket seem fine to me. Some of this is because we made changes to what the buttons are for Fedora. I think it's okay if we make these changes only to our downstream fork.

You can start working on this ticket. :thumbsup:

Hi @alishapapun, the five tasks you list in the ticket seem fine to me. Some of this is because we made changes to what the buttons are for Fedora. I think it's okay if we make these changes only to our downstream fork.
You can start working on this ticket. 👍

Thanks @jflory !

Hi @alishapapun, the five tasks you list in the ticket seem fine to me. Some of this is because we made changes to what the buttons are for Fedora. I think it's okay if we make these changes only to our downstream fork.
You can start working on this ticket. 👍

@jflory7 This is what the footer looks . I have made a PR regarding it #120 .

@alishapapun implemented this in #120. Closing this issue as complete! :clapper:

Metadata Update from @jflory7:
- Issue close_status updated to: complete
- Issue status updated to: Closed (was: Open)

5 years ago

@jflory7 @alishapapun The footer doesn't seem to stick at the bottom when the page has less content. I have attached a snapshot of that case. @alishapapun As you were working on this, I thought I should inform you first if you're still interested to remedy this. Else I'll be happy to take this up!

Screenshot_from_2019-03-03_19-48-11.png

@jflory7 @alishapapun The footer doesn't seem to stick at the bottom when the page has less content. I have attached a snapshot of that case. @alishapapun As you were working on this, I thought I should inform you first if you're still interested to remedy this. Else I'll be happy to take this up!
Screenshot_from_2019-03-03_19-48-11.png

Thanks @shraddhaag ! I will just check the problem and will fix the bug. Thanks for bringing it to notice. :)

The footer doesn't seem to stick at the bottom when the page has less content. I have attached a snapshot of that case.

@shraddhaag Thanks for catching this. :thumbsup: Could you open a new ticket to keep track of it?

The footer doesn't seem to be implemented on the Sender Confirmation Page.

I noticed this too. We can use one ticket to track both the footer fix and the Sender Confirmation Page.

When the ticket is open, if @alishapapun wants to tackle this, I will assign it to her. :smile:

Login to comment on this ticket.

Metadata