Per the upcoming contributing guidelines, if this task is accepted, it should be sent to the upstream project, mxsasha/happinesspackets. Upstream can also make use of this. If upstream merges it, we can apply the patch downstream.

I believe it is better to open PR for both projects, upstream and downstream. Because sometimes a specific feature is helpful for our project but not for the upstream project, or until the upstream project reviews/approves the new feature we might accept and apply it faster etc. But +1 for the approach to open PR for the upstream and downstream project, and depending on the maintainers of each one they can merge the PR or not. @jflory7 does it make sense for you?

@jonatoni Yes, perfect sense. :thumbsup: I approved this ticket for future work.

@jonatoni @jflory7 I'd like to work on this. I'll be sure to open a PR both here and in the upstream project.

@jonatoni @jflory7 On inspection of the upstream project, the prerequisite for this change, an authentication system is missing. Without authentication, the ability to see send and received packets by me [as in the logged in user] has no scope. Thus this change won't be feasible for the upstream project. Could you please give your take on this?

In fedora-happiness-packets, I've implemented the following:

1. A page that lists all the packets sent by the current user. It incorporates the following:
   - Link for the page in navigation called My Sent Packets
   - Lists all the sent messages by the current user
   - Pagination: 5 per page
   - The package is not listed in this page until the status of the message is sent ie only after the sender confirms sending the email, the package is listed here.
   - Name of the recipient is displayed no matter what recipient choses (display the message in archive/share their name or not) as it is the sender, they would obviously know who the receiver is.
   - A default text in place if there are no sent packets.

1. A page that lists all the packages received by the user. It incorporates the following:
   - Link for the page in navigation called My Received Packets
   - Lists all the messages received by the current user
   - The name of the sender is displayed if the sender chose that option while sending else its displayed Anonymous.
   - Pagination: 5 per page
   - A default text in place if there are no received packets.

Please let me know your thoughts on above. If all seems good, I'll be happy to send a PR
Cheers! :)

Without authentication, the ability to see send and received packets by me [as in the logged in user] has no scope. Thus this change won't be feasible for the upstream project. Could you please give your take on this?

Hi @shraddhaag, you're right. Now that I think this through, I don't think it makes sense to send this to upstream since there is no concept of an account there.

In fedora-happiness-packets, I've implemented the following:

Please let me know your thoughts on above. If all seems good, I'll be happy to send a PR

@shraddhaag Both pages are awesome! :tada: Excellent job with this. I think this is ready for a PR. I have some specific feedback below:

• Link for the page in navigation called My Sent Packets
• Link for the page in navigation called My Received Packets

I thought perhaps this layout might be more intuitive / simpler. It's a nitpick I know, but what do you think?

• A default text in place if there are no sent packets.
• A default text in place if there are no received packets.

In the default text when giving the user a call-to-action to send a packet, could you add a hyperlink to the /send/ page?

Awesome work so far! :thumbsup:

I thought perhaps this layout might be more intuitive / simpler. It's a nitpick I know, but what do you think?

It's unclear from how it's worded but the Packets sent : 6 is not the packets sent by the logged in user but in fact a total amount of Happiness Packets exchanged between any two users. #46 was the initial idea pitch.

I was actually thinking of opening a ticket for the following:
1. Change the name of Packets Sent that makes it more clear to it's actual purpose.
2. There is no definite way of knowing if a user is logged in apart from the logout button. User's name could be displayed in the navigation.

@jflory7, if the above two sound reasonable, let me know whether I should open a new ticket or resolve these in a PR.
Also, please suggest on how should I modify the layout, keeping the above in mind?

In the default text when giving the user a call-to-action to send a packet, could you add a hyperlink to the /send/ page?

That's a great idea! I'll surely integrate this :)

Awesome work so far! 👍

Thank you!

It's unclear from how it's worded but the Packets sent : 6 is not the packets sent by the logged in user but in fact a total amount of Happiness Packets exchanged between any two users. #46 was the initial idea pitch.

Oh, actually I didn't know this either. :see_no_evil:

1. Change the name of Packets Sent that makes it more clear to it's actual purpose.

Yes, this definitely makes sense. I think if we figure out what the better wording is, you can submit a pull request without opening a new ticket.

Or do you think it will be more obvious once an instance is running for a while and more and more packets are sent? Maybe this is not intuitive now because we haven't deployed this feature in a larger environment yet.

1. There is no definite way of knowing if a user is logged in apart from the logout button. User's name could be displayed in the navigation.

This seems like a separate topic. This is a good idea for a good first issue ticket. You can file a new ticket for this idea. :thumbsup:

Yes, this definitely makes sense. I think if we figure out what the better wording is, you can submit a pull request without opening a new ticket.

What do you think about Total Happiness spread meter: 6 ? It's a little catchy and removes any discrepancy.

Or do you think it will be more obvious once an instance is running for a while and more and more packets are sent? Maybe this is not intuitive now because we haven't deployed this feature in a larger environment yet.

While that may be the case, I think a slight shift in name would avoid users' confusing between the two. What do think how should we proceed with this one?

There is no definite way of knowing if a user is logged in apart from the logout button. User's name could be displayed in the navigation.
This seems like a separate topic. This is a good idea for a good first issue ticket. You can file a new ticket for this idea. 👍

On it. I'll make a new issue for the same :)

What do you think about Total Happiness spread meter: 6 ? It's a little catchy and removes any discrepancy.

I think Total happiness spread: makes sense! :thumbsup:

While that may be the case, I think a slight shift in name would avoid users' confusing between the two. What do think how should we proceed with this one?

I liked your suggestion for an alternate label. Actually, instead of sending a new PR, you could also file a new issue for it. I can label it as a good first issue and leave it open for someone else to work on. Since it's a small change, it might be a good starter task for a newcomer to the project.

I liked your suggestion for an alternate label. Actually, instead of sending a new PR, you could also file a new issue for it. I can label it as a good first issue and leave it open for someone else to work on. Since it's a small change, it might be a good starter task for a newcomer to the project.

@jflory7 Agreed! This will help more new comers hop on board! I'll open the new issue ASAP.
Also, I sent the PR integrating the suggestion as mentioned above. Could you please review the same? Much thanks! :)

Hi @jflory7 I think this issue can be closed now :)

@shraddhaag Nice catch, closing this ticket as complete per PR #144! :clapper: