Adding a search button for FAS-Username Search field.
Currently, there is no button to be pressed for searching for a FAS user. A button needs to be added to the input field.
A button would be added in the search field. The same is discussed in the ticket #196.
Better user experience and no confusion regarding searching.
Metadata Update from @jflory7: - Issue priority set to: waiting on assignee (was: awaiting triage) - Issue tagged with: PASSED, difficulty - easy, good first issue, help wanted, improvement, type - frontend, type - summer coding
Hello everyone, is there anyone working on this issue. If no could you please assign it to me
Hey @saidat ! Do you know how to add a button to field in crispy form's input field?
Hello everyone, is there anyone working on this issue. If no could you please assign it to me Hey @saidat ! Do you know how to add a button to field in crispy form's input field?
Hello @alishapapun, Django-crispy-forms defines another powerful class called Layout, which allows you to change the way the form fields are rendered. This allows you to set the order of the fields, wrap them in divs or other structures, add html, set ids, classes or attributes to whatever you want, Eg <form method="post" novalidate> {% csrf_token %} {{ form }} <button type="submit">Submit</button> </form> please say something . Thanks
Hello everyone, is there anyone working on this issue. If no could you please assign it to me Hey @saidat ! Do you know how to add a button to field in crispy form's input field? Hello @alishapapun, Django-crispy-forms defines another powerful class called Layout, which allows you to change the way the form fields are rendered. This allows you to set the order of the fields, wrap them in divs or other structures, add html, set ids, classes or attributes to whatever you want, Eg <form method="post" novalidate=""> {% csrf_token %} {{ form }} <button type="submit">Submit</button> </form> please say something . Thanks
Hello @alishapapun, Django-crispy-forms defines another powerful class called Layout, which allows you to change the way the form fields are rendered. This allows you to set the order of the fields, wrap them in divs or other structures, add html, set ids, classes or attributes to whatever you want, Eg <form method="post" novalidate=""> {% csrf_token %} {{ form }} <button type="submit">Submit</button> </form> please say something . Thanks
Yes! We have the form using Layout class, but here we intend to put the search button inside the input field as shown in the mock file . How will you be doing that?
I can include the following code in the end
ButtonHolder(
Submit('submit', 'Update', css_class='btn btn-theme small')
) On 3 Apr 2019 20:38, "Alisha Mohanty" pagure@pagure.io wrote:
alishapapun added a new comment to an issue you are following: `` Hello everyone, is there anyone working on this issue. If no could you please assign it to me Hey @saidat ! Do you know how to add a button to field in crispy form's input field? Hello @alishapapun, Django-crispy-forms defines another powerful class called Layout, which allows you to change the way the form fields are rendered. This allows you to set the order of the fields, wrap them in divs or other structures, add html, set ids, classes or attributes to whatever you want, Eg <form method="post" novalidate=""> {% csrf_token %} {{ form }} <button type="submit">Submit</button> </form> please say something . Thanks Yes! We have the form using Layout class, but here we intend to put the search button inside the input field as shown in the mock file . How will you be doing that? `` To reply, visit the link below or just reply to this email https://pagure.io/fedora-commops/fedora-happiness-packets/issue/208
alishapapun added a new comment to an issue you are following: ``
``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-commops/fedora-happiness-packets/issue/208
I can include the following code in the end ButtonHolder( Submit('submit', 'Update', css_class='btn btn-theme small') )
Sounds good enough! Could you share a screenshot showing the following functionality? :)
hello @alishapapun, can you please tell me the file name which needs change because i have failed to allocate it
On Wed, 3 Apr 2019 at 20:38, Alisha Mohanty pagure@pagure.io wrote:
hello @alishapapun, can you please tell me the file name which needs a change because I have failed to allocate it
In the project folder goto happinesspackets -> messaging -> forms.py in line 54 we have self.helper.layout = Layout(-------). This is the form that is rendered in the send page.
K thanks On 6 Apr 2019 11:18, "Alisha Mohanty" pagure@pagure.io wrote:
alishapapun added a new comment to an issue you are following: `` hello @alishapapun, can you please tell me the file name which needs a change because I have failed to allocate it In the project folder goto happinesspackets -> messaging -> forms.py in line 54 we have self.helper.layout = Layout(-------). This is the form that is rendered in the send page. `` To reply, visit the link below or just reply to this email https://pagure.io/fedora-commops/fedora-happiness-packets/issue/208
In the project folder goto happinesspackets -> messaging -> forms.py in line 54 we have self.helper.layout = Layout(-------). This is the form that is rendered in the send page. ``
But can you still help me I pulled the code yesterday and all my files were updated but wen I run docker compose I got an error can you please help me out because I tried searching on it but haven't configured it out On 6 Apr 2019 11:18, "Alisha Mohanty" pagure@pagure.io wrote:
Hello @alishapapun, thanks but i have got the solution to the problem. Now am fine just i had to change the json name from fas-admin-details.json.example as named in the code to fas-admin-details.json so that the docker can recognize it
On Sat, 6 Apr 2019 at 12:42, Saidat Nanjuki pagure@pagure.io wrote:
saidat added a new comment to an issue you are following: `` But can you still help me I pulled the code yesterday and all my files were updated but wen I run docker compose I got an error can you please help me out because I tried searching on it but haven't configured it out On 6 Apr 2019 11:18, "Alisha Mohanty" pagure@pagure.io wrote: alishapapun added a new comment to an issue you are following: `` hello @alishapapun, can you please tell me the file name which needs a change because I have failed to allocate it In the project folder goto happinesspackets -> messaging -> forms.py in line 54 we have self.helper.layout = Layout(-------). This is the form that is rendered in the send page. `` To reply, visit the link below or just reply to this email https://pagure.io/fedora-commops/fedora-happiness-packets/issue/208 `` To reply, visit the link below or just reply to this email https://pagure.io/fedora-commops/fedora-happiness-packets/issue/208
saidat added a new comment to an issue you are following: `` But can you still help me I pulled the code yesterday and all my files were updated but wen I run docker compose I got an error can you please help me out because I tried searching on it but haven't configured it out On 6 Apr 2019 11:18, "Alisha Mohanty" pagure@pagure.io wrote:
Sounds good! But the PR you addressed in #212 does not work as described in the mockup by Justin in #196. After testing it looks something like this.
<img alt="Screenshot_from_2019-04-09_12-48-02.png" src="/fedora-commops/fedora-happiness-packets/issue/raw/files/5bb1815e203b523d43e7fb2e379172f0039c30bf1b2cff727cb4bcc5c8661a4e-Screenshot_from_2019-04-09_12-48-02.png" />
I would suggest to test the code locally and then publish a PR :)
The issue is covered by PR #221. <img alt="Screenshot_2019-04-22_Send_a_Happiness_Packet.png" src="/fedora-commops/fedora-happiness-packets/issue/raw/files/4b9498ee7cc5d706fc6f2376930d14797b5d66cb0028ba98b4654c06e700d613-Screenshot_2019-04-22_Send_a_Happiness_Packet.png" />
hello @alishapapun, i had also added a search button inside the input field and i was going to create a pr today
Thanks, @saidat for putting efforts, in the issue but since the task not only involves adding a search button but making it functional and making some minor changes for smooth functionality. #221 address all the issues. Could you look for other relevant issues?
Metadata Update from @jflory7: - Issue untagged with: help wanted - Issue assigned to alishapapun - Issue set to the milestone: Summer Coding 2019: community bonding
The issue is solved in #221. So we can close it @jflory7. :clap:
Closing as complete. :clapper: Thanks @alishapapun!
Metadata Update from @jflory7: - Issue close_status updated to: complete - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.