#197 Implement fedmenu overlay on all pages
Opened 2 years ago by jflory7. Modified 2 years ago

Summary

Implement fedmenu on all pages of fedora-happiness-packets

Background

The fedmenu is a common menu that appears on several Fedora-hosted applications. It helps unify the applications in Fedora's infrastructure. Adding the menu overlay to fedora-happiness-packets helps integrate our app into the Fedora ecosystem and creates a sense of connectedness to other Fedora applications.

See a demo here.

Details

fedmenu is a JavaScript menu. The easiest way to integrate it is likely to add it to all the template pages for Django. Other examples of how fedmenu is implemented exist in the fedora-infra GitHub organization.

Outcome

More unity with other Fedora web applications


Hey @jflory7 ! I would like to work on this issue!

For now we can implement linking fedora-happiness-packet with integrating with other application (even if the user is not signed in) . In later stage we can incorporate user functionality of fedmenu in fedora-happiness-packet which can show the badges earned by the user(after implementing the badges functionality #22) .

Hey @jflory7 ! I would like to work on this issue!

@alishapapun Sure thing! :thumbsup:

For now we can implement linking fedora-happiness-packet with integrating with other application (even if the user is not signed in) . In later stage we can incorporate user functionality of fedmenu in fedora-happiness-packet which can show the badges earned by the user(after implementing the badges functionality #22) .

This sounds like the right approach to me. It would be cool to connect the Badges app to fedora-happiness-packets that way. I'm assigning this ticket to you. :smile:

Metadata Update from @jflory7:
- Issue assigned to alishapapun

2 years ago

Hey @jflory7 ! I would like to work on this issue!

@alishapapun Sure thing! 👍

For now we can implement linking fedora-happiness-packet with integrating with other application (even if the user is not signed in) . In later stage we can incorporate user functionality of fedmenu in fedora-happiness-packet which can show the badges earned by the user(after implementing the badges functionality #22) .

This sounds like the right approach to me. It would be cool to connect the Badges app to fedora-happiness-packets that way. I'm assigning this ticket to you. 😄

Hey Justin! I just dig into the implementation part a bit more. I just wanted to ask if the implementation of fedmenu is necessary for local development? Since in other projects(ex Bodhi), I saw its not implemented in the local development rather it is configured, and in deployment it is incorporated. Even I tried to incorporate locally, but it seems the paths of files are quiet defined in files. I am not sure if I am making complete sense, but thats what I think. I would like to have some discussions before heading to start working on it. Thanks @jflory7 !

I just wanted to ask if the implementation of fedmenu is necessary for local development? Since in other projects(ex Bodhi), I saw its not implemented in the local development rather it is configured, and in deployment it is incorporated. Even I tried to incorporate locally, but it seems the paths of files are quiet defined in files.

I'm not sure. @bowlofeggs might be able to give a pointer on how Bodhi implemented fedmenu. @cverna may be able to point to other examples of fedmenu in Fedora's infrastructure.

If someone else is unable to offer pointers first, I'll try to dig into this one next week.

I just wanted to ask if the implementation of fedmenu is necessary for local development? Since in other projects(ex Bodhi), I saw its not implemented in the local development rather it is configured, and in deployment it is incorporated. Even I tried to incorporate locally, but it seems the paths of files are quiet defined in files.

I'm not sure. @bowlofeggs might be able to give a pointer on how Bodhi implemented fedmenu. @cverna may be able to point to other examples of fedmenu in Fedora's infrastructure.
If someone else is unable to offer pointers first, I'll try to dig into this one next week.

That would be highly helpful. Thanks :)

I've never done anything with fedmenu, but here's a link to code in Bodhi that has that text:

https://github.com/fedora-infra/bodhi/search?q=fedmenu&unscoped_q=fedmenu

I've never done anything with fedmenu, but here's a link to code in Bodhi that has that text:
https://github.com/fedora-infra/bodhi/search?q=fedmenu&unscoped_q=fedmenu

I will get a deeper insight into what is happening under the hood and will let you know. :)

Hi @alishapapun! Were you able to make progress on integrating fedmenu? Let us know if we can help.

Metadata Update from @jflory7:
- Custom field Requirement # adjusted to 24

2 years ago

Hi @alishapapun! Were you able to make progress on integrating fedmenu? Let us know if we can help.

Yes, @jflory7! I was able to figure out how to implement fedmenu in case of local development, which is very much different from how it will be set up in the production environment. For local development, I will be making a PR soon. For production, we will change some part of the code while setting up the staging environment.

@alishapapun Thanks for the update. Integrating it in development works for now. It would be great to get that before the end of Outreachy Phase 1 (8 June). Does this sound doable?

We can revisit for production when we get to deploying, but I anticipate this happening in Phase 2.

Documentation will be helpful (when we do get there) about what changes we need to make and why.

Metadata Update from @jflory7:
- Issue untagged with: difficulty - easy, help wanted
- Issue set to the milestone: Summer Coding 2019: phase 1
- Issue tagged with: difficulty - medium

2 years ago

Metadata Update from @jflory7:
- Assignee reset
- Issue marked as depending on: #111
- Issue priority set to: waiting on external (was: waiting on assignee)
- Issue set to the milestone: Summer Coding 2019: phase 2 (was: Summer Coding 2019: phase 1)
- Issue tagged with: blocked

2 years ago

PR #238 merged! :tada: Thanks @alishapapun. I'll leave this issue open for follow-up after #111 is complete.

Could you leave a comment describing what changes you think are required once FHP makes it to production?

PR #238 merged! 🎉 Thanks @alishapapun. I'll leave this issue open for follow-up after #111 is complete.
Could you leave a comment describing what changes you think are required once FHP makes it to production?

The URLs need to be made environment variables. More details in the fedmenu script need to be added, for instance here.

Metadata Update from @jflory7:
- Issue set to the milestone: None (was: Summer Coding 2019: phase 2)

2 years ago

Metadata Update from @jflory7:
- Issue set to the milestone: Summer Coding 2019: phase 2

2 years ago

Login to comment on this ticket.