#115 Different widths of separators on the homepage
Closed: complete 3 years ago by jflory7. Opened 3 years ago by phoenixabhishek.

Hey @jflory7 , I recently caught this slight difference in separator widths that we have on our homepage.
This can be corrected with a slight change in base.html, and custom.css file.

The changes would look like below


PR #116 has been made towards resolving this.

@phoenixabhishek I read this and looked at your PR in #116, but I don't understand why this change is necessary. I can't see a difference between the screenshots. Can you explain why this change is needed?

Metadata Update from @jflory7:
- Issue priority set to: needs review (was: awaiting triage)
- Issue tagged with: needs info, type - frontend, type - summer coding

3 years ago

@jflory if you look at the horizontal lines below the 'What are Fedora Happiness Packets ?' and above the footer, they both are of different lengths.
The one above footer is longer(marked by arrow in the 'Before' image) than the one above.

This gives a look of something being missing in the main content.

The black lines show the area of the main-content and we can see that the footer separator overflows it.

The green lines depict that both the separators are now of same length.

@phoenixabhishek Okay, I see. We can accept this change. Before merging #116, can you also send a pull request to the upstream mxsasha/happinesspackets with this change too? I am guessing upstream could benefit from this change.

Please make a good pull request to send upstream. Once you make it, comment here with a link and I will merge #116 after.

Metadata Update from @jflory7:
- Issue untagged with: needs info
- Issue assigned to phoenixabhishek
- Issue priority set to: waiting on assignee (was: needs review)
- Issue set to the milestone: Summer Coding 2019: community bonding
- Issue tagged with: PASSED, type - upstream

3 years ago

@jflory7 okk, on it :smile: :smile: :smile: :smile: :smile:

@phoenixabhishek Okay, I see. We can accept this change. Before merging #116, can you also send a pull request to the upstream mxsasha/happinesspackets with this change too? I am guessing upstream could benefit from this change.
Please make a good pull request to send upstream. Once you make it, comment here with a link and I will merge #116 after.

Hi @jflory7
I've made the PR 47 on the upstream.
I tried to make it a good PR with the details I could think of were necessary.

Please review

@phoenixabhishek Awesome, nice work! :100: I just merged #116. Thanks for opening the upstream pull request too. Closing as complete. :clapper:

Metadata Update from @jflory7:
- Issue close_status updated to: complete
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Attachments 2
Attached 3 years ago View Comment
Attached 3 years ago View Comment