#16 When source is changed (but name stays), old source is used
Opened 6 years ago by churchyard. Modified 6 years ago

See here: https://src.fedoraproject.org/rpms/esptool/pull-request/1 https://koji.fedoraproject.org/koji/taskinfo?taskID=25236342

What I did:

  • created dummy source file with the same name as original
  • run fedpkg-new sources on it
  • also uploaded it to my fedorapeople and changed the URL

The build should have failed in %prep with:

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.FrXLM3
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf esptool-2.2.1
+ /usr/bin/tar -xof /builddir/build/SOURCES/esptool-2.2.1.tar.gz
/usr/bin/tar: This does not look like a tar archive

gzip: stdin: not in gzip format
/usr/bin/tar: Child returned status 1
/usr/bin/tar: Error is not recoverable: exiting now
error: Bad exit status from /var/tmp/rpm-tmp.FrXLM3 (%prep)

But apparently, the old source was used, because the build succeeded.

Real life problem example: changing PyPI tarball with GitHub tarball as part of the PR (for example in a PR that adds tests, but upstream doesn't put them on PyPI).


Login to comment on this ticket.

Metadata