PR#120: Add type to brew-build ResultsDB updater mapping - fedora-ci/messages

fedora-ci / messages

#120 Add type to brew-build ResultsDB updater mapping

Closed 2 years ago by pholica. Opened 2 years ago by pholica.

fedora-ci/ pholica/messages master into master

Add type to brew-build ResultsDB updater mapping

Pavel Holica • 2 years ago

73c8062

mappings/results/brew-build.test.complete.yaml

file modified

		`@@ -7,3 +7,5 @@`
		`data:`
		`item:`
		`- "${body.artifact.nvr}"`
		`+ type:`
		`+ - "${body.artifact.type}"`

mappings/results/brew-build.test.error.yaml

file modified

		`@@ -7,3 +7,5 @@`
		`data:`
		`item:`
		`- "${body.artifact.nvr}"`
		`+ type:`
		`+ - "${body.artifact.type}"`

mappings/results/brew-build.test.queued.yaml

file modified

		`@@ -7,3 +7,5 @@`
		`data:`
		`item:`
		`- "${body.artifact.nvr}"`
		`+ type:`
		`+ - "${body.artifact.type}"`

mappings/results/brew-build.test.running.yaml

file modified

		`@@ -7,3 +7,5 @@`
		`data:`
		`item:`
		`- "${body.artifact.nvr}"`
		`+ type:`
		`+ - "${body.artifact.type}"`

pholica commented 2 years ago

This should provide information required by the GreenWave.

pholica commented 2 years ago

It seems this got lost in the discussion in the initial merge request: https://pagure.io/fedora-ci/messages/pull-request/109#comment-132592

pholica commented 2 years ago

@lholecek Could you please check this? Do you think anything else is needed?

mvadkert commented 2 years ago

LGTM

Metadata Update from @mvadkert:
- Pull-request tagged with: review-needed

2 years ago

lholecek commented 2 years ago

@lholecek Could you please check this? Do you think anything else is needed?

Looks good, but lot of other things are still missing - depending on what you need:
- scenario
- system_architecture
- system_variant
- scratch

@draval Can you also help review?

pholica commented 2 years ago

@lholecek Could you please check this? Do you think anything else is needed?

Looks good, but lot of other things are still missing - depending on what you need:
- scenario
- system_architecture
- system_variant
- scratch

Thank you, you're right, those should be there as well. Unfortunately I don't know the syntax (e.g. scenario is optional) so I would have spend some time finding out how to actually add those :/

pholica commented 2 years ago

Closing this pull request in favor of https://pagure.io/fedora-ci/messages/pull-request/121

Pull-Request has been closed by pholica

2 years ago