PR#611: Fix the rules for the delivery badge. - fedora-badges

fedora-badges

#611 Fix the rules for the delivery badge.

Closed 5 years ago by sayanchowdhury. Opened 6 years ago by sayanchowdhury.

sayanchowdhury/fedora-badges hotfix/fix-delivery-badge into master

Fix the rules for the delivery badge.

Sayan Chowdhury • 6 years ago

e2f1f8e

rules/pkgdb-hatchling-i.yml

file modified

+3 -3

		`@@ -12,7 +12,7 @@`
		`# We'll perform our more costly check (defined below)`
		`# only when we receive messages that match this trigger.`
		`trigger:`
		`- topic: pkgdb.package.new`
		`+ topic: pagure.project.new`

		`# Once the check has been triggered, this defines what we`
		`# actually check.`
		`@@ -22,9 +22,9 @@`
		`topics:`
		`- "%(topic)s" # The topic of the message that triggered us.`
		`users:`
		`- - "%(msg.package_listing.point_of_contact)s" # The owner of the newly created package.`
		`+ - "%(msg.project.access_users.owner)s" # The owner of the newly created package.`
		`operation: count`
		`condition:`
		`greater than or equal to: 1`

		`- recipient: "%(msg.package_listing.point_of_contact)s"`
		`+ recipient: "%(msg.project.access_users.owner)s"`

sayanchowdhury commented 6 years ago

Signed-off-by: Sayan Chowdhury sayan.chowdhury2012@gmail.com

This PR fixes the issue of the non-delivery of the badge #608

sayanchowdhury commented 6 years ago

@nb @jflory7 Can you review?

jflory7 commented 5 years ago

@sayanchowdhury Sorry for the late response. This looks good to me, but I'm not a fedmsg expert.

I would ping @churchyard or @asamalik if they want to take a look, but otherwise, let's go ahead and get this merged.

churchyard commented 5 years ago

A link to an example matching fedmsg message would help a lot.

jflory7 commented 5 years ago

@sayanchowdhury ^^ Ping, did you get a chance to see this?

jflory7 commented 5 years ago

@sayanchowdhury Ping – did you see this comment? I'm not sure how to move forward with this PR.

carlwgeorge commented 5 years ago

Here is an example message for pagure.project.new.

https://apps.fedoraproject.org/datagrepper/id?id=2018-ad86a7a6-7943-4edd-96a3-e8e17b09ca34&is_raw=true&size=extra-large

This is from the most recent package I've submitted, but my FAS is not in msg.project.access_users.owner. In fact I don't see my FAS anywhere in the message. I don't know what message would work better for this, but here is the releng ticket for creating the distgit repo.

https://pagure.io/releng/fedora-scm-requests/issue/8838

Pull-Request has been closed by sayanchowdhury

5 years ago