#101 Package reviewer
Opened 7 years ago by mrunge. Modified 7 months ago

What the badge should be granted for: package review
Badge description (like "You succesfully approved a package"):
Anything else we need to know:
this should scale 1, 10, 50, 100 packages

Name "Package reviewed"


I think this requires BZ integration (as with several other proposals) as that's the only way 'review passed' is indicated. This doesn't mean we're rejecting the idea, just that it has to wait till that gets done!

Thanks for the idea!

Huge +1 for this one.

FWIW: Huge +1 also from me

Yeah, this would be amazing, but we're still waiting on bugzilla+fedmsg integration.

+1

Copy paste from another ticket, closed as duplicate:
Replying to pnemade:

I have seen similar ticket sometime ago, can't find it now but this requires fedmsg bugzilla integration which I think is not yet implemented.

Bodhi could check for the valid review in Bugzilla, when the package update was successfully sent for the first time.

If you are saying to award badge for number of package reviews done by a reviewer then I am not sure how can bodhi help here. Bodhi is for package maintainers not for package reviewers.

Reviewer could be read from review assignment in Bugzilla.

Replying to [comment:11 raphgro]:

Current discussion thread on devel mailing list about review statistics.
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/I4D77CXDEWEPQCQLEVIRIDQJH2LAEGGH/

Yes, if you would like, I could additionally update the script to play nicely with Badges.

Replying to [comment:12 clime]:

Replying to [comment:11 raphgro]:

Current discussion thread on devel mailing list about review statistics.
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/I4D77CXDEWEPQCQLEVIRIDQJH2LAEGGH/

Yes, if you would like, I could additionally update the script to play nicely with Badges.

That would be really cool with an automated script for doing the awards. Fedmsg can not tell about reviews done in past, rhbz integration is still rudimental. The script should delay for some time period to be somehow tolerant against errors cause people sometimes set the wrong flags in rhbz and change back and forth, like with fedora-review.

Is this badge possible? It looks like it might be.

Artwork concept: Panda with a uniform on and a package on it's shirt with a check mark
Mash up of these badges:
panda: https://badges.fedoraproject.org/badge/famsco-member
package: https://badges.fedoraproject.org/badge/building-the-outer-ring-copr-build-i
Check mark: https://badges.fedoraproject.org/badge/if-you-build-it...-koji-success-i

Metadata Update from @riecatnor:
- Custom field artwork adjusted to has_concept
- Custom field concept_review_passed adjusted to passed (was: 0)
- Custom field has_complete_yaml reset (from Partial)
- Custom field has_description adjusted to on (was: 1)
- Custom field has_name adjusted to on (was: 1)
- Custom field needs_manual_award reset (from 0)
- Custom field triaged adjusted to on (was: 1)
- Issue close_status updated to: None

3 years ago

well, the information is in fedmsg...

See https://apps.fedoraproject.org/datagrepper/id?id=2017-b5959f7d-912a-4abb-87d1-c255c1bced88&is_raw=true&size=extra-large

msg.event.changes[0].added == fedora-review+

It does not holds any information on the user FAS name though (just BZ email).

big +1 on this one though :)

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)
- Issue tagged with: artwork-easy

3 years ago

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

3 years ago

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)
- Issue tagged with: artwork-needed, quality

3 years ago

I want this. But with a larger scale maybe: 100, 250, 500.

@riecatnor Any chance you have some time to work on this?

@eclipseo we can definitely work on this one, but before we go for it, could you please check if this is technically possible?
That would be great =) Thank you!

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

This is technically possible.

Metadata Update from @churchyard:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Metadata Update from @mleonova:
- Issue assigned to mleonova

2 years ago

Here's a proposal for this badge based on @riecatnor's concept:
101-package-reviewer-1.svg
101-package-reviewer-1.png

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

It looks pretty neat! Thank you!

Love it! Should it be development over quality? (Not sure.)

Metadata Update from @churchyard:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Love it! Should it be development over quality? (Not sure.)

What do you think? I am even more not sure :)

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

I like how it looks in green. And doing a review is sort of about quality assurance. So let's keep it green.

Metadata Update from @churchyard:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

@eclipseo @churchyard so should we do 1, 10, 50, 100 or 100, 250, 500? What looks more realistic?

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

1, 10, 50, 100 is good. Not many people get to 100 reviews, and those who do, already have many other badges ;) I think it's most important to have a few badges at the low end, to allow relative beginners to have positive feedback. So I'd even make it 1-5-15-50.

Thank you for your work here. It is great to see this is going somewhere.

I would make it a bit harder to get the badges, since we don't want to encourage people to do reviews just like flipping a coin. That'd make my preference to 1,10,50,100.

I'm partial to higher scale because I've done so many reviews (near 1800) but I guess 1, 10, 50, 100 is more realistic to encourage participation of newcomers.

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Metadata Update from @mleonova:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

these are lookin' good @mleonova - setting to approved :)

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Metadata Update from @riecatnor:
- Custom field artwork adjusted to approved (was: has_concept)
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)
- Issue untagged with: artwork-needed
- Issue tagged with: artwork-approved, ready to push

2 years ago

Can we create the rules file and push this on the Flock workshop?

Metadata Update from @churchyard:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

2 years ago

Flock 2019 badge issue triage, closing old tickets. This one looks so close to ready tho! Any chance someone can take a look at this one and get these pushed? Thanks!!

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

a year ago

And what about the rules file?

Metadata Update from @churchyard:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)

a year ago

Metadata Update from @riecatnor:
- Custom field has_complete_yaml reset (from false)
- Custom field needs_manual_award reset (from false)
- Issue untagged with: difficulty - easy

7 months ago

Login to comment on this ticket.

Metadata
Attachments 5
Related Pull Requests
  • #738 Last updated 5 months ago