#738 Add package-reviewer badge
Opened 2 years ago by raydeeam. Modified 10 months ago
raydeeam/fedora-badges temp_branch2  into  master

empty or binary file added
empty or binary file added
empty or binary file added
empty or binary file added
The added file is too large to be shown here, see it at: svgs/package-reviewer-1.svg
The added file is too large to be shown here, see it at: svgs/package-reviewer-10.svg
The added file is too large to be shown here, see it at: svgs/package-reviewer-100.svg
The added file is too large to be shown here, see it at: svgs/package-reviewer-50.svg

This commit adds package-reviewer badge and fixes #101

rebased onto e4d8ecb

2 years ago

This is a great badge, but I think it is missing a rules file to work correctly?

Metadata Update from @jflory7:
- Pull-request tagged with: needs-rules

2 years ago

Hi, I want to help this PR.

I don't know how to make and test the rules, so I just grep the output with httpie (jq and less to make it easier for me to debug) from fedmsg bus.

First, I want to know when it should be triggered.
I don't think that it depends on the bug status. (NEW, ASSIGNED, POST, MODIFIED, ON_QA, CLOSED, etc.)

I think it should be triggered when users (not others) modify the flag.fedora-review to +. Also it should be tied with bug_id, so it doesn't count as two or more instance.

for example:

{
  "action": "modify",
  "bug_id": 1988832,
  "change_set": "88799.1627967798.15325",
  "changes": [
    {
      "added": "+",
      "field": "flag.fedora-review",
      "field_name": "flag.fedora-review",
      "removed": ""
    }
  ],
  "routing_key": "bug.modify",
  "target": "bug",
  "time": 1627967798,
  "user": {
    "id": 415022,
    "login": "didiksupriadi41@gmail.com",
    "real_name": "Didik Supriadi"
  },
  "who": "didiksupriadi41@gmail.com"
}

* topic: org.fedoraproject.prod.bugzilla.bug.update