copr / copr

Clone

#645 repaired import in builds_logic Closes #644
Merged 5 years ago by praiskup. Opened 5 years ago by hojang.
copr/ hojang/copr import_fix  into  master

file modified
+2 -2 
@@ -22,7 +22,7 @@ 
 

  from coprs import helpers
 

  from coprs.constants import DEFAULT_BUILD_TIMEOUT, MAX_BUILD_TIMEOUT
 

  from coprs.exceptions import MalformedArgumentException, ActionInProgressException, InsufficientRightsException, \
 

-                              UnrepeatableBuildException, RequestCannotBeExecuted
 

+                              UnrepeatableBuildException, RequestCannotBeExecuted, DuplicateException
 

  

  from coprs.logic import coprs_logic
 

  from coprs.logic import users_logic
 
@@ -874,7 +874,7 @@ 
 

                          pkg_name, build.source_type, build.source_json)
 

                      db.session.add(package)
 

                      db.session.commit()
 

-                 except (sqlalchemy.exc.IntegrityError, exceptions.DuplicateException) as e:
 

+                 except (IntegrityError, DuplicateException) as e:
 

                      app.logger.exception(e)
 

                      db.session.rollback()
 

                      return

+1

PR on https://pagure.io/copr/copr/issue/644

Btw, you can just write #644 and it will automatically create a link to the issue for you ;-)

+1

Metadata Update from @praiskup:
- Pull-request tagged with: review
5 years ago

We usually put [frontend] ... into commit message "topic", and fixes #644 somewhere in commit message.

Pull-Request has been merged by praiskup
5 years ago
Metadata
None

review

Changes Summary 1
+2 -2
file changed
frontend/coprs_frontend/coprs/logic/builds_logic.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.