#645 repaired import in builds_logic Closes #644
Merged 7 months ago by praiskup. Opened 7 months ago by hojang.
copr/ hojang/copr import_fix  into  master

@@ -22,7 +22,7 @@ 

  from coprs import helpers

  from coprs.constants import DEFAULT_BUILD_TIMEOUT, MAX_BUILD_TIMEOUT

  from coprs.exceptions import MalformedArgumentException, ActionInProgressException, InsufficientRightsException, \

-                              UnrepeatableBuildException, RequestCannotBeExecuted

+                              UnrepeatableBuildException, RequestCannotBeExecuted, DuplicateException

  

  from coprs.logic import coprs_logic

  from coprs.logic import users_logic

@@ -874,7 +874,7 @@ 

                          pkg_name, build.source_type, build.source_json)

                      db.session.add(package)

                      db.session.commit()

-                 except (sqlalchemy.exc.IntegrityError, exceptions.DuplicateException) as e:

+                 except (IntegrityError, DuplicateException) as e:

                      app.logger.exception(e)

                      db.session.rollback()

                      return

+1

PR on https://pagure.io/copr/copr/issue/644

Btw, you can just write #644 and it will automatically create a link to the issue for you ;-)

Metadata Update from @praiskup:
- Pull-request tagged with: review

7 months ago

We usually put [frontend] ... into commit message "topic", and fixes #644 somewhere in commit message.

Pull-Request has been merged by praiskup

7 months ago