PR#1493: cli: formally deprecate --memory option - copr/copr

Pavel Raiskup • 3 years ago

63e524a

cli/copr_cli/main.py

file modified

+12 -1

		`@@ -10,6 +10,7 @@`
		`import subprocess`
		`import sys`
		`import time`
		`+ import warnings`
		`from collections import defaultdict`

		`import six`
		`@@ -81,6 +82,15 @@`
		`)`


		`+ class ActionDeprecated(argparse.Action):`
frostyx commented 3 years ago This could easily be just a function but I don't mind having a class with `__call__` either.
		`+ """ automate deprecation warnings for options """`
		`+ def __call__(self, parser, namespace, values, option_string=None):`
		`+ options = ", ".join(self.option_strings)`
		`+ warnings.warn("Use of DEPRECATED option: {0}".format(options))`
		`+ # keep the normal "store" behavior`
		`+ setattr(namespace, self.dest, values)`
		`+`
		`+`
		`class Commands(object):`
		`def __init__(self, config_path):`
		`self.config_path = config_path or '~/.config/copr'`
		`@@ -1019,7 +1029,8 @@`
		`help="The copr repo to build the package in. Can be just name of project or even in format username/project or @groupname/project. "`
		`"It can also be in the form project:<tag>, which will put the build into a side repository with the user-chosen tag in its name.")`
		`parser_build_parent.add_argument("--memory", dest="memory",`
		`- help="")`
		`+ help=argparse.SUPPRESS,`
		`+ action=ActionDeprecated)`
		`parser_build_parent.add_argument("--timeout", dest="timeout",`
		`help="")`
		`parser_build_parent.add_argument("--nowait", action="store_true", default=False,`