PR#1146: frontend: revert wrong optimization in createrepo - copr/copr

Pavel Raiskup • 4 years ago

4dcc1e9

file modified

+5 -9

		`@@ -70,21 +70,17 @@`
		`db.session.add(action)`

		`@classmethod`
		`- def send_createrepo(cls, copr, dirnames=None, main_only=True):`
		`- possible_dirnames = [copr_dir.name for copr_dir in copr.dirs`
		`- if not main_only or copr_dir.main]`
		`-`
		`+ def send_createrepo(cls, copr, dirnames=None):`
		`+ possible_dirnames = [copr_dir.name for copr_dir in copr.dirs]`
		`if not dirnames:`
		`# by default we createrepo for all of them`
		`dirnames = possible_dirnames`
		`else:`
		`missing = set(dirnames) - set(possible_dirnames)`
		`if missing:`
		`- # TODO: we should raise NotFoundException here`
		`- #raise exceptions.NotFoundException(`
		`- # "Can't createrepo for {} in {}".format(`
		`- # missing, copr.full_name))`
		`- pass`
		`+ raise exceptions.NotFoundException(`
		`+ "Can't createrepo for {} dirnames in {} project".format(`
		`+ missing, copr.full_name))`
		`data_dict = {`
		`"ownername": copr.owner_name,`
		`"projectname": copr.name,`

file modified

+4 -4

		`@@ -526,7 +526,7 @@`
		`copr_dir = models.CoprDir(`
		`name=dirname, copr=copr, main=main)`

		`- ActionsLogic.send_createrepo(copr, dirnames=[dirname], main_only=False)`
		`+ ActionsLogic.send_createrepo(copr, dirnames=[dirname])`

		`db.session.add(copr_dir)`
		`return copr_dir`
		`@@ -701,15 +701,15 @@`
		`current_chroots = copr.mock_chroots`
		`new_chroots = cls.mock_chroots_from_names(names)`
		`# add non-existing`
		`- run_createrepo = []`
		`+ run_createrepo = False`
		`for mock_chroot in new_chroots:`
		`if mock_chroot not in current_chroots:`
		`db.session.add(`
		`models.CoprChroot(copr=copr, mock_chroot=mock_chroot))`
		`- run_createrepo.append(mock_chroot.name)`
		`+ run_createrepo = True`

		`if run_createrepo:`
		`- ActionsLogic.send_createrepo(copr, dirnames=run_createrepo)`
		`+ ActionsLogic.send_createrepo(copr)`

		`# delete no more present`
		`to_remove = []`