PR#1029: python, keygen: drop comments after %endif - copr/copr

copr / copr

#1029 python, keygen: drop comments after %endif

Merged 4 years ago by praiskup. Opened 4 years ago by praiskup.

Unknown source lint-rpm-warnings into master

python, keygen: drop comments after %endif

Pavel Raiskup • 4 years ago

5f3c423

keygen/copr-keygen.spec

file modified

+1 -1

		`@@ -75,7 +75,7 @@`

		`This package contains document for copr-keygen service.`

		`- %endif # ?fedora`
		`+ %endif`


		`%prep`

python/python-copr.spec

file modified

+5 -5

		`@@ -103,7 +103,7 @@`
		`%{?python_provide:%python_provide python2-copr}`

		`%description -n python2-copr %_description`
		`- %endif # with python2`
		`+ %endif`

		`%if %{with python3}`
		`%package -n python3-copr`
		`@@ -137,7 +137,7 @@`
		`This package contains python interface to access Copr service. Mostly useful`
		`for developers only.`

		`- %endif # with python3`
		`+ %endif`


		`%package -n python-copr-doc`
		`@@ -157,7 +157,7 @@`
		`%if %{with python3}`
		`rm -rf %{py3dir}`
		`cp -a . %{py3dir}`
		`- %endif # with python3`
		`+ %endif`

		`%build`
		`%if %{with python3}`
		`@@ -203,14 +203,14 @@`
		`%license LICENSE`
		`%doc README.rst`
		`%{python3_sitelib}/*`
		`- %endif # with python3`
		`+ %endif`

		`%if %{with python2}`
		`%files -n python2-copr`
		`%license LICENSE`
		`%doc README.rst`
		`%{python2_sitelib}/*`
		`- %endif # with python2`
		`+ %endif`

		`%files -n python-copr-doc`
		`%license LICENSE`

praiskup commented 4 years ago

New RPMs (rpmbuild, rpmlint) print an ugly warning for this:
warning: extra tokens at the end of %endif directive in line 106: %endif # with python2
warning: extra tokens at the end of %endif directive in line 140: %endif # with python3
warning: extra tokens at the end of %endif directive in line 160: %endif # with python3
warning: extra tokens at the end of %endif directive in line 206: %endif # with python3
warning: extra tokens at the end of %endif directive in line 213: %endif # with python2