Learn more about these different git repos.
Other Git URLs
The constants MIN_BUILD_TIMEOUT and MAX_BUILD_TIMEOUT take weird effect, I would expect that when I set MAX_BUILD_TIMEOUT to 20 seconds the build will take 20 seconds but it depends only on time set by DEFAULT_BUILD_TIMEOUT and the constant MAX_BUILD_TIMEOUT is there only to set the upper limit for DEFAULT_BUILD_TIMEOUT which is kind of unexpected. So when I set MAX_BUILD_TIMEOUT to 20 seconds (which can be changed in copr.conf on frontend) and it is a shorter time then for DEFAULT_BUILD_TIMEOUT, it shows the box saying Number must be between 0 and 20. and it is hard to tell where might the problem. I would suggest having only one constant for build timeout. <img alt="Screenshot_from_2020-03-06_14-20-50.png" src="/copr/copr/issue/raw/files/88723bfbd2648cb2ca8d921abc7d761f2a40e8c58d4b1579fb27b81ff1fb1cb6-Screenshot_from_2020-03-06_14-20-50.png" />
Number must be between 0 and 20.
Metadata Update from @praiskup: - Issue priority set to: Low - Issue tagged with: bug, code-cleanup
I'm going to reuse this bug report, and try to define what I think we should do here.
We should pick some reasonable "default" build timeout for generic build, say 2 hours? That would be DEFAULT_BUILD_TIMEOUT. And we should finally implement proper MAX_BUILD_TIMEOUT and set it somewhere to 30 hours.
DEFAULT_BUILD_TIMEOUT
MAX_BUILD_TIMEOUT
Normal builds would use the DEFAULT_BUILD_TIMEOUT, but people could raise the timeout according to their needs up to MAX_BUILD_TIMEOUT.
Metadata Update from @praiskup: - Issue tagged with: RFE
Metadata Update from @praiskup: - Issue priority set to: High (was: Low)
Metadata Update from @schlupov: - Issue assigned to schlupov
Commit 926c1b2 fixes this issue
Login to comment on this ticket.