#1303 Fix the MAX_BUILD_TIMEOUT semantics
Closed: Fixed 3 months ago by praiskup. Opened 9 months ago by schlupov.

The constants MIN_BUILD_TIMEOUT and MAX_BUILD_TIMEOUT take weird effect, I would expect that when I set MAX_BUILD_TIMEOUT to 20 seconds the build will take 20 seconds but it depends only on time set by DEFAULT_BUILD_TIMEOUT and the constant MAX_BUILD_TIMEOUT is there only to set the upper limit for DEFAULT_BUILD_TIMEOUT which is kind of unexpected. So when I set MAX_BUILD_TIMEOUT to 20 seconds (which can be changed in copr.conf on frontend) and it is a shorter time then for DEFAULT_BUILD_TIMEOUT, it shows the box saying Number must be between 0 and 20. and it is hard to tell where might the problem. I would suggest having only one constant for build timeout.
Screenshot_from_2020-03-06_14-20-50.png


Metadata Update from @praiskup:
- Issue priority set to: Low
- Issue tagged with: bug, code-cleanup

9 months ago

I'm going to reuse this bug report, and try to define what I think we should do here.

We should pick some reasonable "default" build timeout for generic build, say
2 hours? That would be DEFAULT_BUILD_TIMEOUT. And we should finally
implement proper MAX_BUILD_TIMEOUT and set it somewhere to 30 hours.

Normal builds would use the DEFAULT_BUILD_TIMEOUT, but people could
raise the timeout according to their needs up to MAX_BUILD_TIMEOUT.

Metadata Update from @praiskup:
- Issue tagged with: RFE

6 months ago

Metadata Update from @praiskup:
- Issue priority set to: High (was: Low)

6 months ago

Metadata Update from @schlupov:
- Issue assigned to schlupov

4 months ago

Login to comment on this ticket.

Metadata
Attachments 1
Related Pull Requests
  • #1480 Merged 3 months ago