#264 Update tests to be compatible with OpenSSL 3.2
Merged 4 months ago by rcritten. Opened 4 months ago by ohollmann.
ohollmann/certmonger master  into  master

file modified
+2 -2
@@ -42,8 +42,8 @@ 

  openssl x509 -out minicert.nss.$size.pem -in minicert.nss.$size -inform der

  # The RSA tests already verify the contents of the requests, so we really only

  # need to care about the signatures passing verification.

- openssl req   -verify -noout < csr.nss.$size 2>&1 | sed 's/Certificate request self-signature //'

- openssl req   -verify -noout < csr.openssl.$size 2>&1 | sed 's/Certificate request self-signature //'

+ openssl req   -verify -noout -in csr.nss.$size 2>&1 | sed 's/Certificate request self-signature //'

+ openssl req   -verify -noout -in csr.openssl.$size 2>&1 | sed 's/Certificate request self-signature //'

  openssl spkac -verify -noout < spkac.nss.$size 2>&1

  openssl spkac -verify -noout < spkac.openssl.$size 2>&1

  openssl verify -CAfile minicert.openssl.$size.pem minicert.openssl.$size.pem 2>&1

@@ -13,7 +13,8 @@ 

  state = STATE_SEARCH

  

  for line in sys.stdin:

-     if state == STATE_SEARCH and ':1.3.6.1.4.1.311.21.7' in line:

+     if state == STATE_SEARCH and (':Microsoft certificate template' in line

+                                   or ':1.3.6.1.4.1.311.21.7' in line):

          state = STATE_FOUND

          continue

  

In test 003-csrgen-ec OpenSSL 3.2 shows warning when reading from stdin, so specify an input file to get rid of this warning.
In test 038-ms-v2-template openssl asn1parse shows ':Microsoft certificate template' instead of ':1.3.6.1.4.1.311.21.7' so we have to check both versions. See https://github.com/openssl/openssl/pull/20986

Thanks for the patch. I have just one request: can you basically put the first comment into the commit message? I think it will provide more context for the change for future devs.

rebased onto bba8321

4 months ago

I updated commit message as requested.

Metadata Update from @rcritten:
- Request assigned

4 months ago

Perfect, thank you. ack.

Pull-Request has been merged by rcritten

4 months ago