389-ds-base

#50910 Issue 50909 - nsDS5ReplicaId cant be set to the old value it had before
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50909  into  master

Download 50910.patch

Bug Description:

We were not handling the process of changing the replica type and id correctly. For one, we were not correctly handling a change to a hub/consumer, but it just happened to work by accident in most cases. In other cases you could not change the rid more than once.

Fix Description:

Changed the value checking to allow ID changes to 65535 which allowed the type/id pointers to be set correctly. Then the checking of the type & ID change combination had to be revised.

Also, removed the option to get just set the RID or type from dsconf. Only replication promotion/demotion should be touching these values.

relates: https://pagure.io/389-ds-base/issue/50909

Looks okay to me :)

Would it be possible to use MAX_REPLICA_ID ?

Except the minor comment, the patch looks also valid to me. Ack

rebased onto e66b946db692e97c1e629545c951228e2155ce23

rebased onto ea4fa549e6daeba648ce11c8c2ce4e7688ffab7b

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3963

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.