Fix regressions and crashes from https://pagure.io/389-ds-base/issue/50506
There were a few places where we should get a copy of the value, and not a reference
https://pagure.io/389-ds-base/pull-request/50621
Metadata Update from @mreynolds: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None
I faced a crash of ns-slapd while running FreeIPA test suite. One of the examples:
ipa-run-tests test_xmlrpc/test_add_remove_cert_cmd.py::TestCertManipIdOverride::test_00_add_idoverrideuser ... test_xmlrpc/test_add_remove_cert_cmd.py::TestCertManipIdOverride::test_00_add_idoverrideuser FAILED [100%] test_xmlrpc/test_add_remove_cert_cmd.py::TestCertManipIdOverride::test_00_add_idoverrideuser ERROR [100%] ... ---------------------------- Captured stdout setup ----------------------------- Ran command: ipaclient.plugins.user.user_del()('testuser', no_preserve=True, preserve=False, version='2.232'): NotFound: testuser: user not found Ran command: ipaserver.plugins.idviews.idview_del()('MyView', version='2.232'): NotFound: MyView: ID View not found ----------------------------- Captured stdout call ----------------------------- Ran command: ipaserver.plugins.user.user_add()('testuser', givenname='John', sn='Donne', version='2.232'): NetworkError: cannot connect to 'ldapi://%2fvar%2frun%2fslapd-IPA-TEST.socket': --------------------------- Captured stdout teardown --------------------------- Ran command: ipaserver.plugins.idviews.idview_del()('MyView', version='2.232'): NetworkError: cannot connect to 'https://master1.ipa.test/ipa/session/json': Internal Server Error Ran command: ipaclient.plugins.user.user_del()('testuser', no_preserve=True, preserve=False, version='2.232'): NetworkError: cannot connect to 'https://master1.ipa.test/ipa/session/json': Internal Server Error ... systemctl status -l --no-pager dirsrv@IPA-TEST.service ● dirsrv@IPA-TEST.service - 389 Directory Server IPA-TEST. Loaded: loaded (/lib/systemd/system/dirsrv@.service; enabled; vendor preset: disabled) Drop-In: /lib/systemd/system/dirsrv@.service.d └─custom.conf /etc/systemd/system/dirsrv@IPA-TEST.service.d └─ipa-env.conf Active: failed (Result: signal) since Wed 2019-09-25 08:05:09 UTC; 8min ago Process: 9837 ExecStartPre=/usr/libexec/dirsrv/ds_systemd_ask_password_acl /etc/dirsrv/slapd-IPA-TEST/dse.ldif (code=exited, status=0/SUCCESS) Process: 9842 ExecStart=/usr/sbin/ns-slapd -D /etc/dirsrv/slapd-IPA-TEST -i /run/dirsrv/slapd-IPA-TEST.pid (code=killed, signal=ABRT) Main PID: 9842 (code=killed, signal=ABRT) Status: "slapd started: Ready to process requests" Sep 25 08:04:04 master1.ipa.test ns-slapd[9842]: [25/Sep/2019:08:04:04.494583612 +0000] - INFO - slapd_daemon - Listening on /var/run/slapd-IPA-TEST.socket for LDAPI requests Sep 25 08:04:04 master1.ipa.test systemd[1]: Started 389 Directory Server IPA-TEST.. Sep 25 08:04:04 master1.ipa.test ns-slapd[9842]: [25/Sep/2019:08:04:04.560427787 +0000] - ERR - schema-compat-plugin - schema-compat-plugin tree scan will start in about 5 seconds! Sep 25 08:04:09 master1.ipa.test ns-slapd[9842]: [25/Sep/2019:08:04:09.567743327 +0000] - ERR - schema-compat-plugin - warning: no entries set up under ou=sudoers,dc=ipa,dc=test Sep 25 08:04:09 master1.ipa.test ns-slapd[9842]: [25/Sep/2019:08:04:09.569306782 +0000] - ERR - schema-compat-plugin - warning: no entries set up under cn=ng, cn=compat,dc=ipa,dc=test Sep 25 08:04:09 master1.ipa.test ns-slapd[9842]: [25/Sep/2019:08:04:09.571888845 +0000] - ERR - schema-compat-plugin - warning: no entries set up under cn=computers, cn=compat,dc=ipa,dc=test Sep 25 08:04:09 master1.ipa.test ns-slapd[9842]: [25/Sep/2019:08:04:09.572759983 +0000] - ERR - schema-compat-plugin - Finished plugin initialization. Sep 25 08:05:09 master1.ipa.test ns-slapd[9842]: malloc_consolidate(): invalid chunk size Sep 25 08:05:09 master1.ipa.test systemd[1]: dirsrv@IPA-TEST.service: Main process exited, code=killed, status=6/ABRT Sep 25 08:05:09 master1.ipa.test systemd[1]: dirsrv@IPA-TEST.service: Failed with result 'signal'.
This came with 1.4.1.7 (previous one 1.4.1.6 is OK).
@slev The crash is triggered by an abort while so far this ticket was hit with sigsev. Although symptom is different there is a good chance that the crash is triggered by that ticket that is the last flavor of a regression introduced by #50506. By any chance do you have core dumped or backstack ?
@tbordaz , i rerun IPA's test suite on top of PR https://pagure.io/389-ds-base/pull-request/50621. All test passed.
I don't have the core dump right now. But if it is still required I can rollback to bare 1.4.1.7 and check it again.
@slev There is a good chance, if this is a regression, that it is fixed in the PR mentioned in this bug. I could provide a Fedora scratch build if you would like to test that?
@mreynolds, these are good news.
Thank you, but I've already built test 389-ds packages (containing 50621) for my distro. That's why I said no concerns related to IPA test suite :) I'm just waiting for PR merge to push this version to an unstable branch.
Commit fce5c6c relates to this ticket
429cb64..f6c7e2c 389-ds-base-1.4.1 -> 389-ds-base-1.4.1
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Thank you!
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/3675
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Log in to comment on this ticket.