cast is not required

cast not required

I think there is a risk of double free in the later call 'dash_guid' that can call slapi_ch_free_string

I think there is a risk of double free in the later call 'dash_guid' that can call slapi_ch_free_string

Well this is how the original code was, and if it is freed the pointer "should" be set to NULL, so the double free "should" not occur.

ahoy, upstream testing here :D the latest version of the patch looks good so far.

This pointer will be overwritten if ldbm_index_parse_entry is called.
I think ldbm_index_parse_entry should free it before overwriting it but then it ldbm_instance_index_config_add_callback should init index_name=NULL;

This pointer will be overwritten if ldbm_index_parse_entry is called.
I think ldbm_index_parse_entry should free it before overwriting it but then it ldbm_instance_index_config_add_callback should init index_name=NULL;

This is a revert to the original code, but I see what you saying. I'll fix this as well.

This pointer will be overwritten if ldbm_index_parse_entry is called.
I think ldbm_index_parse_entry should free it before overwriting it but then it ldbm_instance_index_config_add_callback should init index_name=NULL;

Changes applied, please review...

Thanks Mark. The fix looks good to me. ACK

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3676

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.