#2 Fix bug in DeploymentRequest class
Closed 7 years ago by mizdebsk. Opened 7 years ago by rvais.
rvais/xmvn DepRqBugfix  into  master

@@ -20,6 +20,7 @@ 

  import java.util.ArrayList;

  import java.util.Arrays;

  import java.util.Collections;

+ import java.util.Iterator;

  import java.util.LinkedHashMap;

  import java.util.List;

  import java.util.Map;
@@ -73,7 +74,15 @@ 

  

      public void removeDependency( Artifact dependencyArtifact )

      {

-         dependencies.remove( dependencyArtifact );

+         Iterator<DependencyDescriptor> ddl = dependencies.iterator();

+         while ( ddl.hasNext() )

+         {

+             DependencyDescriptor dd = ddl.next();

+             if ( dd.getDependencyArtifact().equals( dependencyArtifact ) )

+             {

+                 dependencies.remove( dd );

+             }

+         }

      }

  

      public Map<String, String> getProperties()

I used "classic" approach to fix bug in remove method. Coding style and commit should be correct.

Commit looks good, except the message. Please be more specific what it actually fixed.

rebased

7 years ago

I finally changed that commit message ...

Merged manually, closing.

Pull-Request has been closed by mizdebsk

7 years ago