#11 Skip validating xmlto output
Closed 14 days ago by osloup. Opened 2 years ago by khemraj.
khemraj/xmlto master  into  master

file modified
+1 -1
@@ -68,7 +68,7 @@ 

  	doc/xmlif.xml \

  	xmlto.mak

  

- GEN_MANPAGE = FORMAT_DIR=$(top_srcdir)/format $(BASH) ./xmlto -o $(@D) man $<

+ GEN_MANPAGE = FORMAT_DIR=$(top_srcdir)/format $(BASH) ./xmlto --skip-validation -o $(@D) man $<

  man/man1/xmlto.1: doc/xmlto.xml ; $(GEN_MANPAGE)

  man/man1/xmlif.1: doc/xmlif.xml ; $(GEN_MANPAGE)

  

Avoids network access

Signed-off-by: Khem Raj raj.khem@gmail.com

Pull-Request has been closed by osloup

14 days ago

@osloup its fine to close it but would be nice to note down the reason, it was raised 2 years ago with no activity so far.

I wanted to test this first, as I think skipping validation is unnecessary, and I don't see the benefit. Can you elaborate on this change?

when you do build on a machine which is not connected to internet, this fails. Some build machines need to be off internet when building for various reasons.

Since it's our manpages, we can skip the validation to ensure the builds do not fail without the internet. I know about the problem, but I think there is a better solution.

I will add this to the new PR I've created.

Metadata