#72 comps-sync pass 3: Subset of workstation
Merged by dustymabe. Opened by walters.
walters/workstation-ostree-config comps-sync-2  into  master

Download 72.patch

The mental model here is simpler if our base package set is truly a subset of
Workstation.

Extend comps-sync to also support deleting packages not in the Workstation
set. The only exception here is that we still want kernel-modules-extra
which for some reason is only in livecd-tools...I don't understand that.
For now I added a whitelist.

The set of resulting changes here generally makes sense. We lose some
random unnecessary stuff like teamd and dracut-network, and mactel-boot.
We gain things like the desktop background packages, sshpass, and some qt
bits.

+  NetworkManager-openconnect-gnome-1.2.4-9.fc28.x86_64 (fedora-rawhide)
-  NetworkManager-team-1:1.10.2-1.fc28.x86_64 (fedora-rawhide)
+  NetworkManager-ssh-1.2.7-1.fc28.x86_64 (fedora-rawhide)
+  NetworkManager-ssh-gnome-1.2.7-1.fc28.x86_64 (fedora-rawhide)
-  adobe-source-han-sans-cn-fonts-1.004-6.fc28.noarch (fedora-rawhide)
-  adobe-source-han-sans-tw-fonts-1.004-7.fc28.noarch (fedora-rawhide)
+  alsa-ucm-1.1.5-2.fc28.x86_64 (fedora-rawhide)
-  autogen-libopts-5.18.12-6.fc28.x86_64 (fedora-rawhide)
+  cyrus-sasl-plain-2.1.26-37.fc28.x86_64 (fedora-rawhide)
+  desktop-backgrounds-gnome-27.0.0-2.fc28.noarch (fedora-rawhide)
-  dmraid-1.0.0.rc16-37.fc28.x86_64 (fedora-rawhide)
-  dmraid-events-1.0.0.rc16-37.fc28.x86_64 (fedora-rawhide)
-  dracut-config-generic-046-92.git20180118.fc28.1.x86_64 (fedora-rawhide)
-  dracut-network-046-92.git20180118.fc28.1.x86_64 (fedora-rawhide)
-  fcoe-utils-1.0.32-3.fc27.x86_64 (fedora-rawhide)
+  f27-backgrounds-base-27.0.1-3.fc28.noarch (fedora-rawhide)
+  f27-backgrounds-gnome-27.0.1-3.fc28.noarch (fedora-rawhide)
-  fedora-productimg-workstation-27-2.fc28.x86_64 (fedora-rawhide)
-  gnutls-dane-3.6.2-1.fc28.x86_64 (fedora-rawhide)
-  gnutls-utils-3.6.2-1.fc28.x86_64 (fedora-rawhide)
-  hfsplus-tools-540.1.linux3-15.fc28.x86_64 (fedora-rawhide)
-  highlight-3.39-3.fc27.x86_64 (fedora-rawhide)
-  libconfig-1.5-9.fc28.x86_64 (fedora-rawhide)
+  libdnet-1.12-25.fc28.x86_64 (fedora-rawhide)
+  libmspack-0.6-0.2.alpha.fc28.x86_64 (fedora-rawhide)
-  libnl3-cli-3.4.0-3.fc28.x86_64 (fedora-rawhide)
+  libsane-hpaio-3.17.11-8.fc28.x86_64 (fedora-rawhide)
-  libteam-1.27-6.fc28.x86_64 (fedora-rawhide)
-  libvirt-client-4.0.0-1.fc28.x86_64 (fedora-rawhide)
-  lldpad-1.0.1-9.git036e314.fc28.x86_64 (fedora-rawhide)
-  mactel-boot-0.9-16.fc27.x86_64 (fedora-rawhide)
-  naver-nanum-fonts-common-3.020-20.20140930.fc28.noarch (fedora-rawhide)
-  naver-nanum-gothic-fonts-3.020-20.20140930.fc28.noarch (fedora-rawhide)
+  open-vm-tools-10.2.0-3.fc28.x86_64 (fedora-rawhide)
+  open-vm-tools-desktop-10.2.0-3.fc28.x86_64 (fedora-rawhide)
+  pinentry-gnome3-1.1.0-2.fc28.x86_64 (fedora-rawhide)
+  pulseaudio-module-x11-11.1-11.fc28.x86_64 (fedora-rawhide)
+  pulseaudio-utils-11.1-11.fc28.x86_64 (fedora-rawhide)
+  qt5-qtdeclarative-5.10.1-1.fc28.x86_64 (fedora-rawhide)
+  qt5-qtxmlpatterns-5.10.1-1.fc28.x86_64 (fedora-rawhide)
+  realmd-0.16.3-9.fc28.x86_64 (fedora-rawhide)
-  sgpio-1.2.0.10-20.fc28.x86_64 (fedora-rawhide)
+  sshpass-1.06-5.fc28.x86_64 (fedora-rawhide)
-  teamd-1.27-6.fc28.x86_64 (fedora-rawhide)
-  unbound-libs-1.6.8-3.fc28.x86_64 (fedora-rawhide)
-  vlgothic-fonts-20141206-10.fc28.noarch (fedora-rawhide)
+  virtualbox-guest-additions-5.2.6-4.fc28.x86_64 (fedora-rawhide)
+  xmlsec1-openssl-1.2.25-3.fc28.x86_64 (fedora-rawhide)

Looks sane to me.

-  libvirt-client-4.0.0-1.fc28.x86_64 (fedora-rawhide)

:( but understandable.

we shouldn't need this anymore right?

+ open-vm-tools-desktop-10.2.0-3.fc28.x86_64 (fedora-rawhide)

+ virtualbox-guest-additions-5.2.6-4.fc28.x86_64 (fedora-rawhide)

So these are already part of the Workstation set? They kind of stick out like a sore thumb for me.

But otherwise, this looks good.

So these are already part of the Workstation set? They kind of stick out like a sore thumb for me.

Yep, although I think FAW is at its best on bare metal...we want to support being a virt guest too for the same reasons as traditional, right?

  • libvirt-client-4.0.0-1.fc28.x86_64 (fedora-rawhide)

Well we can add it to Workstation, I assume it's an oversight there? That said there's a whole big picture question around whether we should ship the virt stack by default.

we shouldn't need this anymore right?

Yeah I'll delete it.

That said there's a whole big picture question around whether we should ship the virt stack by default.

Right exactly. It seems odd to me that we ship libvirt without libvirt-client. I mean, yeah, you have vagrant-libvirt and GNOME Boxes which use the libvirt API directly, but from a mgmt perspective, libvirt-client is the canonical way to manage libvirt resources, right?

Though I don't mind too much, it's just one rpm-ostree install away. :)

With this PR as is it's only gnome-boxes pulling it in. I was thinking of removing that in a phase 3 after doing some testing.

rebased onto 369c6d4e81a75aa87ee0706b22575c92a52d368d

LGTM, merging this so I can add some comments and open a new PR

Pull-Request has been merged by dustymabe

Metadata