PR#597: passwd: Drop cockpit-ws - workstation-ostree-config

workstation-ostree-config

#597 passwd: Drop cockpit-ws

Opened a year ago by martinpitt. Modified 17 days ago

martinpitt/workstation-ostree-config drop-cockpit-user into main

passwd: Drop cockpit-ws

Martin Pitt • a year ago

d9835f9

group

file modified

-1

		`@@ -47,4 +47,3 @@`
		`systemd-network:x:990:`
		`systemd-resolve:x:989:`
		`systemd-bus-proxy:x:988:`
		`- cockpit-ws:x:987:`

passwd

file modified

-1

		`@@ -29,4 +29,3 @@`
		`systemd-network:x:991:990:systemd Network Management:/:/sbin/nologin`
		`systemd-resolve:x:990:989:systemd Resolver:/:/sbin/nologin`
		`systemd-bus-proxy:x:989:988:systemd Bus Proxy:/:/sbin/nologin`
		`- cockpit-ws:x:988:987:User for cockpit-ws:/:/sbin/nologin`

martinpitt commented a year ago

Cockpit 317 switched to DynamicUser= in [1], so this has been obsolete
for a while. This also never created cockpit-wsinstance and nobody
complained (which is now also not a thing any more since version 330 [2]).

[1] https://github.com/cockpit-project/cockpit/commit/aaa427c09f2502de26b
[2] https://github.com/cockpit-project/cockpit/pull/16811

martinpitt commented a year ago

I'm not sure to what degree you support building without fedora-41-updates -- if not, this should also go into the f41 branch.

zuul commented a year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/23d9bbc3ac9e454e9a704f41ad2c8a03

validate : FAILURE in 14m 26s

martinpitt commented a year ago

The non-synced packages in https://fedora.softwarefactory-project.io/zuul/build/d73ae5789c294496a1d21bcecd3a7dc9 are certainly unrelated?

siosm commented a year ago

They are indeed unrelated. I've made https://pagure.io/workstation-ostree-config/pull-request/598 for those.

Unfortunately, it's unlikely that we'll be able to remove those entries for now as this could shift the UIDs used by other passwd/group entries for users.

See the ongoing discussions in:
- https://gitlab.com/fedora/bootc/tracker/-/issues/31
- https://gitlab.com/fedora/bootc/base-images/-/merge_requests/66
- https://github.com/coreos/fedora-coreos-tracker/issues/155
- https://github.com/containers/bootc/issues/673

Thus while I agree that it is obsolete, is it causing any harm?

martinpitt commented a year ago

Not really harm, I just spotted it and thought it'd be good to clean up.