#106 common-ostree: Add fedora-toolbox
Merged 7 days ago by dustymabe. Opened 2 months ago by rishi.
rishi/workstation-ostree-config wip/rishi/fedora-toolbox  into  master

common-ostree: Add fedora-toolbox
Debarshi Ray • 2 months ago  
file modified
+1 -0

@@ -8,6 +8,7 @@ 

  

      "packages": [

          "buildah",

+         "fedora-toolbox",

          "flatpak",

          "flatpak-builder",

          "git-core",

rebased onto 60f4a40

2 months ago

+1 - we should wait until rpms have passed bodhi updates and then apply to master and f29 branches at the same time.

ping back when in stable

Okay, I will do that. Thanks Dusty.

since the first version of fedora-toolbox is in stable should we merge this now? Is there any reason to wait for pending discussions to finish?

FWIW I briefly played with it on SB28 and got:

$ fedora-toolbox create
/usr/bin/fedora-toolbox: failed to create working container
$ rpm -q fedora-toolbox && rpm-ostree status -b
fedora-toolbox-0.0.1-1.fc28.noarch
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: last run 18h ago
BootedDeployment:
● ostree://fedora-atomic:fedora/28/x86_64/workstation
                   Version: 28.20181109.0 (2018-11-09T02:40:59Z)
                BaseCommit: 546ff4260fcd931f00ae857749a1e87913f05863166e886ecc632802942a4219
           LayeredPackages: compat-ffmpeg28 emacs fuse-sshfs git-evtag keepassx krb5-workstation libXScrnSaver libvirt libvirt-client oci-kvm-hook opensc origin-clients pcsc-lite-ccid strace stratis-cli stratisd
                            tilix tmux virt-manager xsel ykclient ykpers
             LocalPackages: fedora-toolbox-0.0.1-1.fc28.noarch

Didn't really get a chance to trace through.

Broadly speaking...I am OK to merge this but let's note that it's "experimental" or something and we may change it in the future?

works for me

[mv@lenivo ~]$ rpm -q fedora-toolbox && rpm-ostree status -b
fedora-toolbox-0.0.1-1.fc29.noarch
State: idle
AutomaticUpdates: disabled
BootedDeployment:
● ostree://fedora-workstation:fedora/29/x86_64/silverblue
                   Version: 29.20181115.0 (2018-11-15T00:59:29Z)
                BaseCommit: a8a12427cd1301a689ce0618d3c37cd84c77c7be5f0c43b2d6fa3b4dd3ed52a7
              GPGSignature: Valid signature by 5A03B4DD8254ECA02FDA1637A20AA56B429476B4
           LayeredPackages: fedora-toolbox i3 tlp tmux
             LocalPackages: flash-plugin-31.0.0.122-release.x86_64 flash-player-ppapi-31.0.0.122-release.x86_64
[mv@lenivo ~]$ fedora-toolbox enter
🔹[mv@toolbox ~]$

@walters It might be a runc or podman issue, so knowing those versions would help. You could also run fedora-toolbox with the --verbose flag for some more debug spew.

colin is on f28 and milos is on f29, so maybe that's the difference

Yeah, seems to work ok with me ok SB2B in some brief testing.

OK so I don't want to stall things here forever...I would love to have more time to play with fedora-toolbox more myself and/or think about the intersection with coreos-toolbox and how we can unify them.

But...having something here is absolutely crucial to telling our story and while there are a variety of efforts floating around here I think it's important that we try to consolidate some.

So I'm +1 to merging this PR.

i'm +1 for merging this

Pull-Request has been merged by dustymabe

7 days ago
Metadata