#54 clarify that the API accepts comma-separated result IDs
Merged 6 years ago by dcallagh. Opened 6 years ago by dcallagh.
dcallagh/waiverdb multiple-result-ids  into  master

file modified
+12
@@ -125,6 +125,18 @@ 

      assert res_data['data'][0]['result_id'] == 123

  

  

+ def test_filtering_waivers_by_multiple_result_ids(client, session):

+     create_waiver(session, result_id=123, username='foo-1', product_version='foo-1')

+     create_waiver(session, result_id=234, username='foo-2', product_version='foo-1')

+     create_waiver(session, result_id=345, username='foo-2', product_version='foo-1')

+     r = client.get('/api/v1.0/waivers/?result_id=123,345')

+     res_data = json.loads(r.get_data(as_text=True))

+     assert r.status_code == 200

+     assert len(res_data['data']) == 2

+     assert res_data['data'][0]['result_id'] == 345

+     assert res_data['data'][1]['result_id'] == 123

+ 

+ 

  def test_filtering_waivers_by_product_version(client, session):

      create_waiver(session, result_id=123, username='foo-1', product_version='release-1')

      create_waiver(session, result_id=124, username='foo-1', product_version='release-2')

file modified
+2 -1
@@ -81,7 +81,8 @@ 

  

          :query int page: The page to get.

          :query int limit: Limit the number of items returned.

-         :query int result_id: Filter the waivers by result ID.

+         :query int result_id: Filter the waivers by result ID. Accepts one or

+             more result IDs separated by commas.

          :query string product_version: Filter the waivers by product version.

          :query string username: Filter the waivers by username.

          :query string since: A ISO 8601 formatted datetime (e.g. 2017-03-16T13:40:05+00:00)

no initial comment

Pull-Request has been merged by dcallagh

6 years ago