PR#43: Dockerfile: set some labels - waiverdb

waiverdb

#43 Dockerfile: set some labels

Merged 6 years ago by dcallagh. Opened 6 years ago by dcallagh.

dcallagh/waiverdb docker-labels into master

Dan Callaghan • 6 years ago

7852867

Dockerfile

file modified

		`@@ -1,4 +1,9 @@`
		`FROM centos:7`
		`+ LABEL \`
		`+ name="WaiverDB application" \`
		`+ vendor="WaiverDB developers" \`
mprahl commented 6 years ago Perhaps "Red Hat" or "Factory 2.0" here?
		`+ license="GPLv2+" \`
		`+ build-date=""`
		`RUN yum -y install epel-release && yum -y clean all`
		`# The caller should build a waiverdb RPM package using ./rpmbuild.sh and then pass it in this arg.`
		`ARG waiverdb_rpm`

dcallagh commented 6 years ago

The CentOS base image already sets "name", "vendor", "license", and
"build-date" labels so we should explicitly overwrite them in our
Dockerfile. Otherwise we inherit the CentOS labels, and our container
will show up in OpenShift as being CentOS instead of WaiverDB.

mprahl commented on line 5 of Dockerfile 6 years ago

Perhaps "Red Hat" or "Factory 2.0" here?

ralph commented 6 years ago

:+1: from me. I'm neutral on @mprahl's suggestion. Any of those options (waiverdb devs, factory 2, RH, or whoever) works for me.

On the other hand, say "Red Hat" might be a little heavy-handed -- it might appear as if it were a supported Red hat product, which it is not. It is an upstream project.

dcallagh commented 6 years ago

RIght... I am not too sure about the exact semantics of the "vendor" label (there appears to be no spec or anything, I think CentOS just made it up). But I don't want to imply that Red Hat or anyone else is selling you this container.

In the end it doesn't really matter what we have here, I just wanted it not to say vendor is CentOS since that is clearly wrong. :-)

dcallagh commented 6 years ago

In the end it doesn't really matter what we have here, I just wanted it not to say vendor is CentOS since that is clearly wrong. :-)