PR#392: Remove start call for the stomp.py connection as it is deprecated - waiverdb

waiverdb

#392 Remove start call for the stomp.py connection as it is deprecated

Merged 3 years ago by lholecek. Opened 3 years ago by vmaljulin.

vmaljulin/waiverdb RHELWF-2180 into master

Remove start call for the stomp.py connection as it is deprecated

Valerij Maljulin • 3 years ago

361e74f

waiverdb/utils.py

file modified

-1

		`@@ -91,7 +91,6 @@`
		`raise RuntimeError('stomp was configured to publish messages,, '`
		`'but connection is not configured in STOMP_CONFIGS')`
		`conn = stomp.Connection(**configs['connection'])`
		`- conn.start()`
		`conn.connect(**configs.get('credentials', {}))`
		`try:`
		`yield conn`

vmaljulin commented 3 years ago

JIRA: RHELWF-2180

lholecek commented 3 years ago

Did you find a documentation about the depracation?

Why did WaiverDB use it in the first place?

Please update the commit message if you find the docs.

vmaljulin commented 3 years ago

Did you find a documentation about the depracation?

Why did WaiverDB use it in the first place?

Please update the commit message if you find the docs.

I've looked through commits for the stomp.py and found that since 2017 this function contained only "pass", so it actually didn't do anything and was removed in 2020.

rebased onto 361e74f

3 years ago

lholecek commented 3 years ago