#331 Add deps for Greenwave segment test - integration test
Closed 2 years ago by gnaponie. Opened 2 years ago by gnaponie.
gnaponie/waiverdb gw-segment-test-deps-needed  into  master

@@ -15,6 +15,7 @@ 

      python3-sphinx python3-sphinxcontrib-httpdomain \

      python3-ldap \

      origin-clients \

+     python3-werkzeug \

Shouldn't this dependency be already required by waiverdb? It not in spec file but it's used in code.

    # install tini, a tiny but valid init for containers

    && wget -O /usr/local/bin/tini "https://github.com/krallin/tini/releases/download/v${TINI_VERSION}/tini" \

    && chmod +rx /usr/local/bin/tini \

Shouldn't this dependency be already required by waiverdb? It not in spec file but it's used in code.

I believe these are dependencies for the Jenkins instance that is running, not waiverdb itself.
Let's wait for @rayson anyhow. I might be wrong.

The dependency should be already installed by dnf -y builddep waiverdb.spec (same Dockerfile).

I don't see "python3-werkzeug" in the spec file. Am I missing something?

I don't see "python3-werkzeug" in the spec file. Am I missing something?

It's dependency of python3-flask.

ok great :)
let's drop this one then.

Pull-Request has been closed by gnaponie

2 years ago