#322 Allow optional trailing slash for about endpoint
Merged 4 years ago by gnaponie. Opened 4 years ago by lholecek.
lholecek/waiverdb allow-about-trailing-slash  into  master

file modified
+5 -3
@@ -628,10 +628,12 @@ 

          "time data 'asdf' does not match format '%Y-%m-%dT%H:%M:%S.%f'"

  

  

- def test_about_endpoint(client):

-     r = client.get('/api/v1.0/about')

-     output = json.loads(r.get_data(as_text=True))

+ @pytest.mark.parametrize('trailing_slash', ('', '/'))

+ def test_about_endpoint(client, trailing_slash):

+     r = client.get('/api/v1.0/about' + trailing_slash)

      assert r.status_code == 200

+ 

+     output = json.loads(r.get_data(as_text=True))

      assert output['version'] == __version__

      assert output['auth_method'] == client.application.config['AUTH_METHOD']

  

file modified
+1 -1
@@ -668,5 +668,5 @@ 

  api.add_resource(WaiverResource, '/waivers/<int:waiver_id>')

  api.add_resource(FilteredWaiversResource, '/waivers/+filtered')

  api.add_resource(GetWaiversBySubjectsAndTestcases, '/waivers/+by-subjects-and-testcases')

- api.add_resource(AboutResource, '/about')

+ api.add_resource(AboutResource, '/about', strict_slashes=False)

  api.add_resource(MonitorResource, '/metrics')

Accessing "api/v1.0/about/" shouldn't give 404.

Signed-off-by: Lukas Holecek hluk@email.cz

Pull-Request has been merged by gnaponie

4 years ago