+1

python-devel openldap-devel looks like something that pip needs to build some binaries.

Can you just use python3-ldap?

Yeah, let's use python3-ldap.
/me was trying over and over with creative ways to fix that.

It seems odd that the unit tests use PyPi for deps except for this dep.

:thumbsup:

I'm making some tests on that... since the CI fails. No review is needed at the moment...
Suggestions are welcome.

Isn't it enough to do git commit --amend --no-edit && git push -f to trigger the CI build?

Looks like CI uses the Jenkinsfile from master branch (WAIVERDB_MAIN_BRANCH OpenShift template parameter). From file "openshift/pipelines/templates/waiverdb-build-template.yaml":

- name: WAIVERDB_MAIN_BRANCH
  displayName: Name of the main branch.
  description: If WAIVERDB_MAIN_BRANCH equals WAIVERDB_GIT_REF, this is a post-merge build, otherwise it's a pre-merge build.
  value: master

This doesn't make much sense. For PR (pre-merge build) this should use the new Jenkinsfile, otherwise the master branch can break after PR is merged.

@rayson Can you provide some help here? I'm not able to make the pre-merge run correctly even if I think I've put all the dependencies.

I tried to fix using the Jenkinsfile from PR instead of master in #317 and #318, unfortunately it doesn't seem to be possible to specify refspec parameter (+refs/pull/*/head:refs/remotes/origin/pr/*) for Jenkins in OpenShift template to make it possible to fetch the PR branch.

How about moving the code from Jenkinsfile that is expected to change in future to scripts? This could make it also bit clearer.

Looks like you just have to update the test dependencies in "openshift/containers/jenkins-slave/Dockerfile" (#319), commit changes to a branch (e.g. "update-jenkins-slave") and rebuild with:

oc start-build --from-repo=. --commit=update-jenkins-slave waiverdb-premerge-jenkins-slave

Closing this PR.