PR#283: Fix message format for "container-image.test.complete" topic - waiverdb

waiverdb

#283 Fix message format for "container-image.test.complete" topic

Merged 5 years ago by rayson. Opened 5 years ago by lholecek.

lholecek/waiverdb valid-umb-message into master

Fix message format for "container-image.test.complete" topic

Lukas Holecek • 5 years ago

146d964

openshift/pipelines/templates/waiverdb-integration-test.Jenkinsfile

file modified

+2 -1

		`@@ -177,7 +177,7 @@`
		`"docs": "https://pagure.io/waiverdb/blob/master/f/openshift",`
		`"irc": "#pnt-devops-dev",`
		`"email": "pnt-factory2-devel@redhat.com",`
		`- "environment": "development"`
		`+ "environment": "stage"`
		`},`
		`"run": {`
		`"url": "${env.BUILD_URL}",`
		`@@ -203,6 +203,7 @@`
		`"category": "integration",`
		`"status": "${currentBuild.result == null \|\| currentBuild.result == 'SUCCESS' ? 'passed':'failed'}",`
		`"xunit": "${env.BUILD_URL}/artifacts/junit-functional-tests.xml",`
		`+ "generated_at": "${new Date().format("yyyy-MM-dd'T'HH:mm:ss'Z'", TimeZone.getTimeZone('UTC'))}",`
		`"namespace": "waiverdb-test",`
		`"version": "0.1.0"`
		`}`

lholecek commented 5 years ago

Validated in: https://pagure.io/fedora-ci/messages

Changes value for field "environment" to "stage" - it can be either
"stage" or "production".

Adds required field "generated_at" - contains date/time in ISO 8601
format.

Signed-off-by: Lukas Holecek hluk@email.cz

lholecek commented 5 years ago

@rayson Can you review? (I didn't properly test this on Jenkins.)

rayson commented 5 years ago

PS.
I didn't test it on Jenkins either, but I tried running new Date().format("yyyy-MM-dd'T'HH:mm:ss'Z'", TimeZone.getTimeZone('UTC')) on GroovyConsole and got the following output:

2019-02-21T08:06:48Z

lholecek commented 5 years ago

PS.
I didn't test it on Jenkins either, but I tried running new Date().format("yyyy-MM-dd'T'HH🇲🇲ss'Z'", TimeZone.getTimeZone('UTC')) on GroovyConsole and got the following output:
2019-02-21T08:06:48Z

Yup, that's the only part I could test in console. :)

@rayson Thanks for checking.

rayson commented 5 years ago

Commit b145b67 fixes this pull-request