Learn more about these different git repos.
Other Git URLs
35d78a5
@@ -12,6 +12,9 @@
node('rcm-tools-jslave-rhel-7') {
checkout scm
+ stage('Invoke Flake8') {
+ sh 'flake8'
This won't execute with the same rules as the one enforced in tox. You can execute just the lint rule in tox with tox -e lint so it runs with the same rules it runs for developers.
tox -e lint
As the doc says, it will run with the rules configured in the tox.ini. http://flake8.pycqa.org/en/latest/user/configuration.html#configuration-locations
Whoa, fancy. I've been needlessly duplicating my configuration to setup.cfg. :thumbsup:
+ }
stage('Build SRPM') {
sh './rpmbuild.sh -bs'
archiveArtifacts artifacts: 'rpmbuild-output/**'
Better put this in its own build stage. It's not part of building the SRPM.
rebased
@dcallagh this one as well, please, :smile:
You can just invoke python instead of /usr/bin/python.
/usr/bin/python
(We have to invoke /usr/bin/mock with the full path because of the mess with /usr/sbin/mock setuid helper.)
/usr/bin/mock
/usr/sbin/mock
Yeah, I thought there must be a reason to call mock like that. I've updated the PR.
:+1: but ideally test it in Jenkins before merging
👍 but ideally test it in Jenkins before merging
Yeah, that reminds me that I need to get flask-oidc built in eng-rhel-7.
:+1: here.
I've tested it in Jenkins and it works as expected.
Pull-Request has been merged by mjia
This won't execute with the same rules as the one enforced in tox. You can execute just the lint rule in tox with
tox -e lint
so it runs with the same rules it runs for developers.