#365 Broken tests with fedora-messaging 2.0.0
Closed: Fixed 5 years ago by lholecek. Opened 5 years ago by mkovarik.

Waiverdb unit tests are failing on Fedora 31, because of new fedora-messaging

==================================== ERRORS ====================================
_____ ERROR at setup of TestAccessControl.test_ldap_host_base_not_defined ______

app = <Flask 'waiverdb.app'>

    @pytest.yield_fixture
    def client(app):
        """A Flask test client. An instance of :class:`flask.testing.TestClient`
        by default.
        """
        with app.test_client() as client:
>           with patch('fedora_messaging.api._session_cache'):

tests/conftest.py:60: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3.7/site-packages/mock/mock.py:1369: in __enter__
    original, local = self.get_original()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <mock.mock._patch object at 0x7fc84b1497d0>

    def get_original(self):
        target = self.getter()
        name = self.attribute

        original = DEFAULT
        local = False

        try:
            original = target.__dict__[name]
        except (AttributeError, KeyError):
            original = getattr(target, name, DEFAULT)
        else:
            local = True

        if name in _builtins and isinstance(target, ModuleType):
            self.create = True

        if not self.create and original is DEFAULT:
            raise AttributeError(
>               "%s does not have the attribute %r" % (target, name)
            )
E           AttributeError: <module 'fedora_messaging.api' from '/usr/lib/python3.7/site-packages/fedora_messaging/api.py'> does not have the attribute '_session_cache'

/usr/lib/python3.7/site-packages/mock/mock.py:1343: AttributeError
_____ ERROR at setup of TestAccessControl.test_ldap_host_defined_base_not ______

@cverna @pingou Can you please have a look when you have time?
Thank you

Fixing this in https://pagure.io/waiverdb/pull-request/377.

We should bump Fedora version for the container image (in "openshift/containers/waiverdb/Dockerfile").

@gnaponie @vmaljulin @mkovarik Do you think it's OK?

Log in to comment on this ticket.

Metadata
Related Pull Requests
  • #377 Merged 5 years ago
  • #367 Closed 3 years ago