From ff0bfe3494e56df3c473d18f5c309643b8bc8596 Mon Sep 17 00:00:00 2001
From: Eduardo Lima (Etrunko) <etrunko@redhat.com>
Date: Aug 21 2019 13:37:47 +0000
Subject: ovirt-foreign-menu: Only set domain_valid once


In the case of having a valid storage domain without any ISO files, this
variable can be reset to FALSE again in the next iteration of the loop,
resulting in a misleading error message presented to the user.

Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

---

diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 4ec0858..c2f43e6 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -669,6 +669,7 @@ static gboolean storage_domain_validate(OvirtForeignMenu *menu G_GNUC_UNUSED,
     }
 #endif
 
+    g_debug ("Storage domain '%s' is %s", name, ret ? "valid" : "not valid");
     g_free(name);
     return ret;
 }
@@ -697,10 +698,12 @@ static void storage_domains_fetched_cb(GObject *source_object,
     while (g_hash_table_iter_next(&iter, NULL, (gpointer *)&domain)) {
         OvirtCollection *file_collection;
 
-        domain_valid = storage_domain_validate(menu, domain);
-        if (!domain_valid)
+        if (!storage_domain_validate(menu, domain))
             continue;
 
+        if (!domain_valid)
+            domain_valid = TRUE;
+
         file_collection = ovirt_storage_domain_get_files(domain);
         if (file_collection != NULL) {
             if (menu->priv->files) {