From ad40386fa27607f092b216489841b77262a29776 Mon Sep 17 00:00:00 2001 From: Fabiano FidĂȘncio Date: May 03 2016 06:04:23 +0000 Subject: msi: Depend on mingw-adwaita-icon-theme Instead of maintain a file which includes every single icon that we use from adwaita-icon-theme (adwaita-icons-needed.wxi.in), let's depend on mingw-adwaita-icon-theme directly. It reduces considerably the maintainability and the risk to have missing icons. Although, the size of the final binary gets increased from ~35MB to ~50MB. Resolves: rhbz#1301064 Signed-off-by: Fabiano FidĂȘncio Acked-by: Christophe Fergeau --- diff --git a/configure.ac b/configure.ac index 3ee5c46..9426350 100644 --- a/configure.ac +++ b/configure.ac @@ -237,7 +237,6 @@ AM_CONDITIONAL(ENABLE_UPDATE_MIMEDB, test x$enable_update_mimedb = xyes) AC_CONFIG_FILES([ Makefile data/Makefile - data/adwaita-icons-needed.wxi data/virt-viewer.wxs icons/Makefile icons/16x16/Makefile diff --git a/data/Makefile.am b/data/Makefile.am index 9385d00..821c171 100644 --- a/data/Makefile.am +++ b/data/Makefile.am @@ -4,13 +4,12 @@ MANUFACTURER = Virt Manager Project EXTRA_DIST = \ spice-xpi-client-remote-viewer \ - adwaita-icons-needed.wxi.in \ virt-viewer.wxs.in \ $(NULL) # this make sure those files are regenerated when they change # (in maintainer-mode) -all-local: adwaita-icons-needed.wxi virt-viewer.wxs +all-local: virt-viewer.wxs if OS_WIN32 diff --git a/data/adwaita-icons-needed.wxi.in b/data/adwaita-icons-needed.wxi.in deleted file mode 100644 index 417a811..0000000 --- a/data/adwaita-icons-needed.wxi.in +++ /dev/null @@ -1,807 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in index 03f7548..9838265 100644 --- a/data/virt-viewer.wxs.in +++ b/data/virt-viewer.wxs.in @@ -22,7 +22,7 @@ - + @@ -95,19 +95,6 @@ - - - - - - - - - - - - @@ -130,7 +117,7 @@ - + @@ -144,7 +131,6 @@ - diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in index ddea296..3109f5f 100644 --- a/mingw-virt-viewer.spec.in +++ b/mingw-virt-viewer.spec.in @@ -22,6 +22,8 @@ Group: Applications/Internet URL: http://virt-manager.org/ Source0: ftp://virt-manager.org/downloads/virt-viewer/virt-viewer-%{version}.tar.gz +BuildRequires: mingw32-adwaita-icon-theme +BuildRequires: mingw64-adwaita-icon-theme BuildRequires: mingw32-filesystem >= 23 BuildRequires: mingw64-filesystem >= 23 BuildRequires: mingw32-glib2 >= @GLIB2_REQUIRED@ @@ -62,9 +64,8 @@ BuildRequires: intltool BuildRequires: icoutils BuildRequires: dos2unix BuildRequires: hicolor-icon-theme -BuildRequires: adwaita-icon-theme BuildRequires: hwdata -BuildRequires: msitools >= 0.95-2 +BuildRequires: msitools >= 0.95-4 BuildArch: noarch