c0806dc domain: Fix migratable XML with graphics/@listen

Authored and Committed by Jiri Denemark 8 years ago
    domain: Fix migratable XML with graphics/@listen
    
    As of commit 6992994, we set graphics/@listen attribute according to the
    first listen child element even if that element is of type='network'.
    This was done for backward compatibility with applications which only
    support the original listen attribute. However, by doing so we broke
    migration to older libvirt which tried to check that the listen
    attribute matches one of the listen child elements but which did not
    take type='network' elements into account.
    
    We are not concerned about compatibility with old applications when
    formatting domain XML for migration for two reasons. The XML is consumed
    only by libvirtd and the IP address associated with type='network'
    listen address on the source host is just useless on the destination
    host. Thus, we can safely avoid propagating the type='network' IP
    address to graphics/@listen attribute when creating migratable XML.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1265111
    
    Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
    
        
file modified
+7 -9