4fb8ff9 conf: Drop virDomainChrDeviceType.targetTypeAttr

Authored and Committed by Andrea Bolognani 6 years ago
43 files changed. 56 lines added. 61 lines removed.
src/conf/domain_conf.c
file modified
+4 -7
src/conf/domain_conf.h
file modified
+0 -1
src/vz/vz_sdk.c
file modified
+1 -2
tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml
file modified
+2 -2
tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml
file modified
+2 -2
tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml
file modified
+1 -1
tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml
file modified
+1 -1
tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+console-virtio.xml
file modified
+2 -2
tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml
file modified
+2 -2
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml
file modified
+2 -2
tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml
file modified
+2 -2
tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml
file modified
+2 -2
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml
file modified
+2 -2
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-missing.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-no-address.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport-nospice.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
file modified
+3 -3
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml
file modified
+2 -2
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml
file modified
+1 -1
tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml
file modified
+1 -1
    conf: Drop virDomainChrDeviceType.targetTypeAttr
    
    This attribute was used to decide whether to format the type
    attribute of the <target> element, but the logic didn't take into
    account all possible cases and as such could lead to unexpected
    results. Moreover, it's one more thing to keep track of, and can
    easily fall out of sync with other attributes.
    
    Now that we have VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE, we can
    use that value to signal that no specific target type has been
    configured for the serial device and as such the attribute should
    not be formatted at all. All other values are now formatted.
    
    Signed-off-by: Andrea Bolognani <abologna@redhat.com>
    Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
    
        
file modified
+4 -7
file modified
+0 -1
file modified
+1 -2