From 1f89039ddb9a6844d6204c1bac7f4d393448a2c9 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Oct 25 2016 20:09:24 +0000 Subject: qemu: Move setting of conf_disk in qemuDomainSetBlockIoTune Since persistent_def is the only place that uses it, let's just keep it closer to where it's used. --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f971e65..93c3d4a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17455,15 +17455,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, goto endjob; } - if (persistentDef) { - if (!(conf_disk = virDomainDiskByName(persistentDef, path, true))) { - virReportError(VIR_ERR_INVALID_ARG, - _("missing persistent configuration for disk '%s'"), - path); - goto endjob; - } - } - if (def) { supportMaxOptions = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DRIVE_IOTUNE_MAX); @@ -17556,6 +17547,12 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, } if (persistentDef) { + if (!(conf_disk = virDomainDiskByName(persistentDef, path, true))) { + virReportError(VIR_ERR_INVALID_ARG, + _("missing persistent configuration for disk '%s'"), + path); + goto endjob; + } oldinfo = &conf_disk->blkdeviotune; if (!set_bytes) { info.total_bytes_sec = oldinfo->total_bytes_sec;