0ecd685 Give virDomainDef parser & formatter their own flags

Authored and Committed by berrange 9 years ago
41 files changed. 321 lines added. 273 lines removed.
src/bhyve/bhyve_driver.c
file modified
+5 -4
src/conf/domain_conf.c
file modified
+142 -152
src/conf/domain_conf.h
file modified
+33 -0
src/conf/snapshot_conf.c
file modified
+4 -4
src/esx/esx_driver.c
file modified
+8 -5
src/hyperv/hyperv_driver.c
file modified
+2 -1
src/libvirt_private.syms
file modified
+1 -0
src/libxl/libxl_domain.c
file modified
+1 -1
src/libxl/libxl_driver.c
file modified
+12 -11
src/libxl/libxl_migration.c
file modified
+3 -3
src/lxc/lxc_driver.c
file modified
+6 -6
src/openvz/openvz_driver.c
file modified
+7 -6
src/parallels/parallels_driver.c
file modified
+1 -1
src/phyp/phyp_driver.c
file modified
+3 -2
src/qemu/qemu_domain.c
file modified
+8 -4
src/qemu/qemu_driver.c
file modified
+14 -12
src/qemu/qemu_migration.c
file modified
+4 -4
src/security/security_apparmor.c
file modified
+1 -1
src/security/virt-aa-helper.c
file modified
+2 -1
src/test/test_driver.c
file modified
+10 -8
src/uml/uml_driver.c
file modified
+5 -5
src/vbox/vbox_common.c
file modified
+8 -6
src/vmware/vmware_driver.c
file modified
+5 -4
src/xen/xen_driver.c
file modified
+5 -4
src/xen/xend_internal.c
file modified
+3 -3
src/xen/xm_internal.c
file modified
+2 -2
src/xenapi/xenapi_driver.c
file modified
+2 -2
tests/bhyvexml2argvtest.c
file modified
+1 -1
tests/bhyvexml2xmltest.c
file modified
+2 -2
tests/domainsnapshotxml2xmltest.c
file modified
+1 -1
tests/lxcxml2xmltest.c
file modified
+2 -2
tests/openvzutilstest.c
file modified
+1 -1
tests/qemuagenttest.c
file modified
+1 -1
tests/qemuhotplugtest.c
file modified
+3 -3
tests/qemuxml2argvtest.c
file modified
+1 -1
tests/qemuxml2xmltest.c
file modified
+6 -3
tests/qemuxmlnstest.c
file modified
+1 -1
tests/vmx2xmltest.c
file modified
+1 -1
tests/xmconfigtest.c
file modified
+2 -2
tests/xml2sexprtest.c
file modified
+1 -1
tests/xml2vmxtest.c
file modified
+1 -1
    Give virDomainDef parser & formatter their own flags
    
    The virDomainDefParse* and virDomainDefFormat* methods both
    accept the VIR_DOMAIN_XML_* flags defined in the public API,
    along with a set of other VIR_DOMAIN_XML_INTERNAL_* flags
    defined in domain_conf.c.
    
    This is seriously confusing & error prone for a number of
    reasons:
    
     - VIR_DOMAIN_XML_SECURE, VIR_DOMAIN_XML_MIGRATABLE and
       VIR_DOMAIN_XML_UPDATE_CPU are only relevant for the
       formatting operation
     - Some of the VIR_DOMAIN_XML_INTERNAL_* flags only apply
       to parse or to format, but not both.
    
    This patch cleanly separates out the flags. There are two
    distint VIR_DOMAIN_DEF_PARSE_* and VIR_DOMAIN_DEF_FORMAT_*
    flags that are used by the corresponding methods. The
    VIR_DOMAIN_XML_* flags received via public API calls must
    be converted to the VIR_DOMAIN_DEF_FORMAT_* flags where
    needed.
    
    The various calls to virDomainDefParse which hardcoded the
    use of the VIR_DOMAIN_XML_INACTIVE flag change to use the
    VIR_DOMAIN_DEF_PARSE_INACTIVE flag.
    
        
file modified
+5 -4
file modified
+142 -152
file modified
+33 -0
file modified
+4 -4
file modified
+8 -5
file modified
+2 -1
file modified
+1 -0
file modified
+1 -1
file modified
+12 -11
file modified
+3 -3
file modified
+6 -6
file modified
+7 -6
file modified
+3 -2
file modified
+8 -4
file modified
+14 -12
file modified
+4 -4
file modified
+10 -8
file modified
+5 -5
file modified
+8 -6
file modified
+5 -4
file modified
+5 -4
file modified
+3 -3
file modified
+2 -2
file modified
+2 -2
file modified
+1 -1
file modified
+2 -2
file modified
+2 -2
file modified
+1 -1
file modified
+1 -1
file modified
+3 -3
file modified
+1 -1
file modified
+6 -3
file modified
+1 -1
file modified
+1 -1
file modified
+2 -2
file modified
+1 -1
file modified
+1 -1